Project

General

Profile

Actions
Copy link

Patch #19339

closed

Put news articles into <article> tags

Added by An Phan about 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
News
Target version:
3.1.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The news article HTML should be wrapped in <article> tags. This follows HTML5 practices, and makes theme styling easier.

Files

better-news-structure.diff (1.34 KB) better-news-structure.diff An Phan, 2015-03-11 07:18
Actions
Copy link
 #1

Updated by Toshi MARUYAMA about 8 years ago

  • Target version set to 3.1.0
Actions
Copy link
 #2

Updated by Jean-Philippe Lang almost 8 years ago

Why not doing the same on the news detail page, eg. /news/1?

Actions
Copy link
 #3

Updated by An Phan almost 8 years ago

We sure can, but is it necessary though? The news details are directly wrapped in the #main div itself.

Actions
Copy link
 #4

Updated by Jean-Philippe Lang almost 8 years ago

  • Subject changed from Put news articles into, well, <article> tags to Put news articles into <article> tags
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Comitted in r14308, thanks.

Actions
Copy link

Also available in: Atom PDF