Project

General

Profile

Actions
Copy link

Defect #1941

closed

Latest news appear on the homepage for projects with the News module disabled

Added by Jakob Skjerning over 15 years ago. Updated over 15 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
News
Target version:
-
Start date:
2008-09-24
Due date:
% Done:

100%

Estimated time:
Resolution:
Fixed
Affected version:

Description

To reproduce.

  1. Go to a Project with the News module enabled.
  2. Make sure the Project has at least one recent piece of News.
  3. Go to the Project Settings and disable the News module.
  4. Go to the Homepage .

Result

The "Latest news" on the Homepage contains news from the Project. The link to the News can be clicked and results in a "403: You are not authorized to access this page".

Expected

News from projects with the News module disabled is not displayed in the "Latest news" box.

  • Redmine: r1901
  • Ruby: 1.8.6 (2007-03-13 patchlevel 0) [i686-darwin8.9.1]
  • Rails: 2.1.0
  • MySQL: 4.1.22

Files

latest_news_should_only_return_news_from_projects_with_news_enabled.diff (4.12 KB) latest_news_should_only_return_news_from_projects_with_news_enabled.diff Jakob Skjerning, 2008-09-24 14:36
Actions
Copy link
 #1

Updated by Jakob Skjerning over 15 years ago

I went ahead and fixed this, patch is attached. It turned out the News model had no tests at all, so I went ahead and added a few as well - including one that verifies my issue and fix.

Actions
Copy link
 #2

Updated by Jean-Philippe Lang over 15 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

I've fixed it in r1910 using a slightly different approach and added your tests.
Thanks.

Actions
Copy link

Also available in: Atom PDF