Project

General

Profile

Actions
Copy link

Patch #19706

closed

Issue show : optimizations

Added by Jérôme BATAILLE almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Performance
Target version:
2.6.5
Start date:
Due date:
% Done:

0%

Estimated time:

Description

# in app/controllers/issue_controller.rb in
def show
  @changesets = @issue.changesets.visible.includes([:repository, :user, :issues]).all

# in app/helper/issues_helper in :
def render_descendants_tree(issue)
  issue_list(issue.descendants.visible.includes([:status, :priority, :tracker]).sort_by(&:lft)) do |child, level|
Actions
Copy link
 #1

Updated by Jérôme BATAILLE almost 9 years ago

Some optimizations could be made in parse_redmine_links too, because issues and priorities are loaded multiple times (from cache though)

Actions
Copy link
 #2

Updated by Jean-Philippe Lang almost 9 years ago

  • Category set to Performance
  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version set to 3.0.3

Patch committed with slight changes, thanks.

Actions
Copy link
 #3

Updated by Jean-Philippe Lang almost 9 years ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #4

Updated by Jean-Philippe Lang almost 9 years ago

  • Target version changed from 3.0.3 to 2.6.5
Actions
Copy link
 #5

Updated by Jérôme BATAILLE almost 9 years ago

Thanks for having reviewed this patch !

Actions
Copy link

Also available in: Atom PDF