Project

General

Profile

Actions

Feature #19886

closed

Raise wiki edits comments limit to 1024

Feature #19886: Raise wiki edits comments limit to 1024

Added by Future Link Corporation pkgsrc team over 11 years ago. Updated about 11 years ago.

Status:
Closed
Priority:
Low
Category:
Wiki
Target version:
Resolution:
Fixed

Description

See: source:/trunk/app/models/wiki_content.rb#L25

The comments field in the wiki_content_versions table is defined as having a length of 1024 characters:

Click to expand wiki_content_versions table definition...

Yet, user comments are truncated at 255:

Click to expand patch...

Let's not do that. :)

Note: This patch (partly) makes the comment field mandatory. That might not be what you want. It would be nice to have a way to require this field without patching the application though. :)


Related issues 1 (0 open — 1 closed)

Copied from Redmine - Feature #19885: Raise time entries comments limit to 1024ClosedJean-Philippe LangActions

Updated by Future Link Corporation pkgsrc team over 11 years ago Actions #1

  • Copied from Feature #19885: Raise time entries comments limit to 1024 added

Updated by Toshi MARUYAMA over 11 years ago Actions #2

  • Status changed from New to Needs feedback

"comments" of "wiki_content_versions" is defined as 255.
source:tags/3.0.3/db/migrate/029_create_wiki_contents.rb#L19

I think you changed manually.

Updated by Future Link Corporation pkgsrc team over 11 years ago Actions #3

Yes, you are correct. We did. Can that field be made longer by default? The length of 255 characters is rather short and doesn't allow for detailed time entries.

Updated by Toshi MARUYAMA over 11 years ago Actions #4

See r4402.

Updated by Future Link Corporation pkgsrc team over 11 years ago Actions #5

The diff you referenced doesn't apply to the wiki content versions comment field.

Updated by Toshi MARUYAMA over 11 years ago Actions #6

If you want to modify db definition, you need to make db migrate file.
  • source:trunk/db/migrate/20101114115114_change_projects_name_limit.rb
  • source:trunk/db/migrate/20101114115359_change_projects_identifier_limit.rb

Updated by Toshi MARUYAMA over 11 years ago Actions #7

  • Tracker changed from Patch to Feature
  • Status changed from Needs feedback to New

Because there is no completed patch, I change tracker.

Updated by Toshi MARUYAMA over 11 years ago Actions #8

  • Target version set to 3.2.0

Updated by Jean-Philippe Lang about 11 years ago Actions #9

  • Subject changed from Comment field length for wiki edits is unnecessarily short to Raise wiki edits comments limit to 1024
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Limit raised to 1024 in r14622.

Actions

Also available in: PDF Atom