Project

General

Profile

Actions

Feature #20822

closed

No private issue notifications

Feature #20822: No private issue notifications

Added by Karel Pičman about 11 years ago. Updated about 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Email notifications
Target version:
-
Resolution:
Invalid

Description

Email notifications of private issues shouldn't be sent to all project members


Files

private_issue_notifications.diff (946 Bytes) private_issue_notifications.diff Karel Pičman, 2015-09-23 12:52

Updated by Toshi MARUYAMA about 11 years ago Actions #1

  • Subject changed from Private issue notifications to No private issue notifications

Updated by Toshi MARUYAMA about 11 years ago Actions #2

  • Tracker changed from Patch to Feature

Updated by Toshi MARUYAMA about 11 years ago Actions #3

Sorry, I cannot get your intention.
Your patch send mail to assignee, right?
Your patch change behavior.
I think it is better to add checkbox on issue form such as ChiliProject.
https://www.chiliproject.org/issues/310

Updated by Karel Pičman about 11 years ago Actions #4

My intention is related to PRIVATE issues only. While private issues are hidden to the project members except the author and the assignee, the email notifications are distributed to all project members. And that's wrong, I think.

Updated by Toshi MARUYAMA about 11 years ago Actions #5

Karel Pičman wrote:

While private issues are hidden to the project members except the author and the assignee,

It is not true.
Private issue visibility can be defined at role "Issues visibility".

Updated by Karel Pičman about 11 years ago Actions #6

You're right. From that perspective my patch is wrong. However, the problem persists. In case of an update of a private issue, all members of the project get notifications despite the fact they are not allowed to view the issue.

Updated by Karel Pičman about 11 years ago Actions #7

  • Status changed from New to Resolved

I see it now. That's a complete misunderstanding from my site. Sorry for your time. You can close it as Invalid.

Updated by Toshi MARUYAMA about 11 years ago Actions #8

Karel Pičman wrote:

all members of the project get notifications despite the fact they are not allowed to view the issue.

Really?

source:tags/3.1.1/app/models/issue.rb#L889

    # Remove users that can not view the issue
    notified.reject! {|user| !visible?(user)}

Updated by Toshi MARUYAMA about 11 years ago Actions #9

  • Status changed from Resolved to Closed
  • Resolution set to Invalid

Thank you.

Actions

Also available in: PDF Atom