Patch #20906

Fix mulitple tab navigation highlighting and content hiding

Added by Felix Gliesche about 2 years ago. Updated about 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Code cleanup/refactoring
Target version:3.1.2

Description

Assuming you have multiple tab navigations on one page, clicking on a tab leads to the false behaviour that highlighted tabs in another tab navigation lose their highlighting. This is caused by the current implementation of showTab in application.js, because it only assumes the case of having only one tab navigation on one page (see source:trunk/public/javascripts/application.js#L319). This assumption also causes the behaviour, that all elements that match the selector

div#content .tab-content

will be hidden if one tab is clicked (see source:trunk/public/javascripts/application.js#L318).

The attached patch takes the possibility of having several tab navigations into consideration. It does not remove the highlighting for other tab navigations and hides the tab content of the corresponding tab context.

0001-Update-showTab-to-work-for-multiple-tabs-on-same-pag.patch Magnifier (1022 Bytes) Felix Gliesche, 2015-10-05 18:41


Related issues

Related to Redmine - Patch #20271: Fix for multiple tabs on the same page Closed

Associated revisions

Revision 14728
Added by Jean-Philippe Lang about 2 years ago

Fix mulitple tab navigation highlighting and content hiding (#20906).

Patch by Felix Gliesche.

History

#1 Updated by Jan from Planio www.plan.io about 2 years ago

  • Target version set to Candidate for next minor release

#2 Updated by Jan from Planio www.plan.io about 2 years ago

  • Related to Patch #20271: Fix for multiple tabs on the same page added

#3 Updated by Jean-Philippe Lang about 2 years ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version changed from Candidate for next minor release to 3.1.2

Committed, thanks.

#4 Updated by Jean-Philippe Lang about 2 years ago

  • Category changed from UI to Code cleanup/refactoring
  • Status changed from Resolved to Closed

Also available in: Atom PDF