Redmine

It works as expected! 100%.
I'm totally satisfied with current implementation. thanks for this feature :)

Using the feature, I found another point regarding watcher that watcher could not be notified at the moment of issue creation. (similar with #398)
If watcher managed with assigned issue number, it would be hard to determine the issue number before issue creation.
This might requires too many rework on watcher system to support.

Is there any trick possible to assign watcher before issue creation?

Jean-Philippe Lang wrote:

Feature added in r2077.
Note that it will only work if the sender has the 'Add issue watchers' permission.

I did it this way because watchers have already received the original email (the one that created the issue).
But watchers could be easily added before the notification is sent:
source:/trunk/app/models/mail_handler.rb@2079#L95

The problem is that watchers would receive 2 emails: the email sent by the user and the notification. Do you think it's really usefull ?

I'm not sure the suggestion is right approach.
As you pointed out, the weakpoint is duplicated notification. But strong point is that watcher can send instant feedback using notification from redmine without visiting redmine.

Most of my collegues tends to use e-mail rather than redmine for issue discussion and this make me hard to keep track of history on the issue. That's why I suggested watcher notified at the moment of issue creation.

Jean-Philippe Lang wrote:

The problem is that watchers would receive 2 emails: the email sent by the user and the notification. Do you think it's really usefull ?

Jean-Philippe Lang wrote:

I did it this way because watchers have already received the original email (the one that created the issue).
But watchers could be easily added before the notification is sent:
source:/trunk/app/models/mail_handler.rb@2079#L95

Exchanging source:/trunk/app/models/mail_handler.rb@2136#L97 with Line 99 do not send notification when issue created.
Could I get unofficial patch for watcher notification of created issue?

(Watchers miss that the issue has been created in redmine. They just tend to reply e-mail.)

Oops, you need to apply the following patch too:

Index: app/models/mailer.rb
===================================================================
--- app/models/mailer.rb    (revision 2009)
+++ app/models/mailer.rb    (copie de travail)
@@ -28,6 +28,7 @@
                     'Issue-Author' => issue.author.login
     redmine_headers 'Issue-Assignee' => issue.assigned_to.login if issue.assigned_to
     recipients issue.recipients
+    cc(issue.watcher_recipients - @recipients)
     subject "[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}] (#{issue.status.name}) #{issue.subject}" 
     body :issue => issue,
          :issue_url => url_for(:controller => 'issues', :action => 'show', :id => issue)

And I think you're right, I'll do the change to the mainline.

Thanks, JP! r2164 is working well.

Change done in r2195. Watchers are now added before the notification is sent.

The patch doesn't seem to be compatible with Redmine 4.0+ version. Can anyone please assist ?