Defect #24000

z-index children menu should be greater than content

Added by Kirill Ponomarev about 2 years ago. Updated almost 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:3.3.2
Resolution:Fixed Affected version:

Description

In Redmine 3.3.0.stable.15884 we have:

#main-menu .menu-children {
  z-index:1;
}

#content {
  z-index: 10;
}

It should be:

#main-menu .menu-children {
  z-index: 11;
}

0001-setting-z-index-of-project-menu-drop-down-to-45-abov.patch Magnifier (837 Bytes) Jan from Planio www.plan.io, 2016-10-26 14:01

Related issues

Related to Redmine - Feature #15880: Consistent, global button/menu to add new content Closed

Associated revisions

Revision 15954
Added by Jean-Philippe Lang almost 2 years ago

Setting z-index of project menu drop down to 45, above context menus, below modals (#24000).

Patch by Jan Schulz-Hofen.

Revision 16044
Added by Jean-Philippe Lang almost 2 years ago

Merged r15954 (#24000).

History

#1 Updated by Toshi MARUYAMA almost 2 years ago

  • Related to Feature #15880: Consistent, global button/menu to add new content added

#2 Updated by Toshi MARUYAMA almost 2 years ago

Please explain more details about what the current problem is and what you expect.

#3 Updated by Makoto Kawasaki almost 2 years ago

Some uses have a problem that #conten element is over .menu-children element.
https://github.com/makotokw/redmine-theme-gitmike/issues/31#issuecomment-255307502

I have never seen this problem in my environment.

#4 Updated by Jan from Planio www.plan.io almost 2 years ago

I agree that a z-index of 1 may be too low given the fact that #content has a z-index of 10.

I am setting the z-index to 45 now, which is above context menus but below modals which I think would make sense.

Could someone please try the attached patch and see if the problem with said theme is still reproducible?

#5 Updated by Gregory Van der Steen almost 2 years ago

Jan from Planio www.plan.io wrote:

I agree that a z-index of 1 may be too low given the fact that #content has a z-index of 10.

I am setting the z-index to 45 now, which is above context menus but below modals which I think would make sense.

Could someone please try the attached patch and see if the problem with said theme is still reproducible?

Terrific! Tested and works in the following themes: default, classic, gitmike, flatly light, circle, a1, alternate

#6 Updated by Jan from Planio www.plan.io almost 2 years ago

  • Target version set to Candidate for next minor release

Thanks for testing, I am setting this as a candidate for the next bugfix release then.

#7 Updated by Toshi MARUYAMA almost 2 years ago

  • Target version changed from Candidate for next minor release to 3.3.2

#8 Updated by Jean-Philippe Lang almost 2 years ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Fix committed, thanks.

#9 Updated by Jean-Philippe Lang almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF