Actions
Defect #24473
open
CSV Export Very slow for issues with lots of Custom Fields
Status:
New
Priority:
Normal
Assignee:
-
Category:
Performance
Target version:
-
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Affected version:
Description
Environment: Redmine version 3.3.0.stable Ruby version 2.2.1-p85 (2015-02-26) [x86_64-linux] Rails version 4.2.6 Environment production Database adapter Mysql2
So I tried to investigate why, when exporting an issue with lots of custom fields, my log file would look like this:
CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]] CACHE (0.0ms) SELECT `issues`.* FROM `issues` WHERE `issues`.`id` = 94261 LIMIT 1 [["id", 94261]]
There is one line per custom field apparently.
My investigation led this method (in lib/redmine/field_format.rb):
def formatted_custom_value(view, custom_value, html=false)
formatted_value(view, custom_value.custom_field, custom_value.value, custom_value.customized, html)
# |
#THIS CALL
end
When custom_value.customized is called, this leads to the Customized object being loaded. Here, Customized is an issue, and it would be reloaded once per custom field.
Some caching would be needed here, where we directly provide the customized object to this method, although I am not sure what's best to do...
Files
Related issues
Updated by 
Updated by Toshi MARUYAMA 
Updated by
Actions