Project

General

Profile

Actions
Copy link

Patch #25731

closed

Use only one if with two conditions in issue show instead of two ifs (if in if)

Added by Marius BĂLTEANU about 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

I think that there are no reasons to use two ifs in source:trunk/app/views/issues/show.html.erb#L67. I propose to use only one with both conditions.

Files

use_only_one_if.patch (870 Bytes) use_only_one_if.patch Marius BĂLTEANU, 2017-05-01 16:39
Actions
Copy link
 #1

Updated by Go MAEDA about 8 years ago

  • Target version set to 3.4.0

Thanks for the patch. Setting target version to 3.4.0.

Actions
Copy link
 #2

Updated by Toshi MARUYAMA almost 8 years ago

  • Status changed from New to Closed
  • Target version deleted (3.4.0)

Committed in trunk r16581, thanks.

Actions
Copy link

Also available in: Atom PDF