Patch #2635

Display notice on forum updates

Added by Brad Beattie over 10 years ago. Updated 5 months ago.

Status:ClosedStart date:2009-01-31
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Forums
Target version:4.0.1

Description

When posting a comment to a news item, the notice label_comment_added is displayed to the user. I figured that it was inconsistent not to do the same for forum comments, so I created the following patch.

### Eclipse Workspace Patch 1.0
#P Redmine
Index: lang/en.yml
===================================================================
--- lang/en.yml    (revision 2344)
+++ lang/en.yml    (working copy)
@@ -536,6 +536,7 @@
 label_message_new: New message
 label_message_posted: Message added
 label_reply_plural: Replies
+label_reply_added: Reply added
 label_send_information: Send account information to the user
 label_year: Year
 label_month: Month
Index: app/controllers/messages_controller.rb
===================================================================
--- app/controllers/messages_controller.rb    (revision 2338)
+++ app/controllers/messages_controller.rb    (working copy)
@@ -47,6 +47,7 @@
     end
     if request.post? && @message.save
       attach_files(@message, params[:attachments])
+      flash[:notice] = l(:label_message_posted)
       redirect_to :action => 'show', :id => @message
     end
   end
@@ -60,6 +61,7 @@
     if !@reply.new_record?
       attach_files(@reply, params[:attachments])
     end
+    flash[:notice] = l(:label_reply_added)
     redirect_to :action => 'show', :id => @topic
   end

2635-show-notice-on-forum-updates.diff Magnifier (2.83 KB) Go MAEDA, 2018-12-15 15:27

Associated revisions

Revision 17738
Added by Go MAEDA 5 months ago

Display notice on forum updates (#2635).

Patch by Go MAEDA.

Revision 17740
Added by Go MAEDA 5 months ago

Merged r17738 from trunk to 4.0-stable (#2635).

History

#1 Updated by Brad Beattie over 10 years ago

  • Assignee set to Jean-Philippe Lang

#2 Updated by Go MAEDA 5 months ago

+1
I think the notices will improve usability. The attached patch adds notices on create/update/delete operation on forum messages.

#3 Updated by Go MAEDA 5 months ago

  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
  • Estimated time deleted (0.20)

Committed.

#4 Updated by Go MAEDA 5 months ago

  • Subject changed from Display notice on forum thread or reply creation to Display notice on forum updates

#5 Updated by Go MAEDA 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF