Project

General

Profile

Actions

Patch #2635

closed

Display notice on forum updates

Added by Brad Beattie about 15 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Forums
Target version:
Start date:
2009-01-31
Due date:
% Done:

0%

Estimated time:

Description

When posting a comment to a news item, the notice label_comment_added is displayed to the user. I figured that it was inconsistent not to do the same for forum comments, so I created the following patch.

### Eclipse Workspace Patch 1.0
#P Redmine
Index: lang/en.yml
===================================================================
--- lang/en.yml    (revision 2344)
+++ lang/en.yml    (working copy)
@@ -536,6 +536,7 @@
 label_message_new: New message
 label_message_posted: Message added
 label_reply_plural: Replies
+label_reply_added: Reply added
 label_send_information: Send account information to the user
 label_year: Year
 label_month: Month
Index: app/controllers/messages_controller.rb
===================================================================
--- app/controllers/messages_controller.rb    (revision 2338)
+++ app/controllers/messages_controller.rb    (working copy)
@@ -47,6 +47,7 @@
     end
     if request.post? && @message.save
       attach_files(@message, params[:attachments])
+      flash[:notice] = l(:label_message_posted)
       redirect_to :action => 'show', :id => @message
     end
   end
@@ -60,6 +61,7 @@
     if !@reply.new_record?
       attach_files(@reply, params[:attachments])
     end
+    flash[:notice] = l(:label_reply_added)
     redirect_to :action => 'show', :id => @topic
   end

Files

Actions #1

Updated by Brad Beattie about 15 years ago

  • Assignee set to Jean-Philippe Lang
Actions #2

Updated by Go MAEDA over 5 years ago

+1
I think the notices will improve usability. The attached patch adds notices on create/update/delete operation on forum messages.

Actions #3

Updated by Go MAEDA over 5 years ago

  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
  • Estimated time deleted (0.20 h)

Committed.

Actions #4

Updated by Go MAEDA over 5 years ago

  • Subject changed from Display notice on forum thread or reply creation to Display notice on forum updates
Actions #5

Updated by Go MAEDA over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF