Actions
Patch #2635
closedDisplay notice on forum updates
Description
When posting a comment to a news item, the notice label_comment_added is displayed to the user. I figured that it was inconsistent not to do the same for forum comments, so I created the following patch.
### Eclipse Workspace Patch 1.0
#P Redmine
Index: lang/en.yml
===================================================================
--- lang/en.yml (revision 2344)
+++ lang/en.yml (working copy)
@@ -536,6 +536,7 @@
label_message_new: New message
label_message_posted: Message added
label_reply_plural: Replies
+label_reply_added: Reply added
label_send_information: Send account information to the user
label_year: Year
label_month: Month
Index: app/controllers/messages_controller.rb
===================================================================
--- app/controllers/messages_controller.rb (revision 2338)
+++ app/controllers/messages_controller.rb (working copy)
@@ -47,6 +47,7 @@
end
if request.post? && @message.save
attach_files(@message, params[:attachments])
+ flash[:notice] = l(:label_message_posted)
redirect_to :action => 'show', :id => @message
end
end
@@ -60,6 +61,7 @@
if !@reply.new_record?
attach_files(@reply, params[:attachments])
end
+ flash[:notice] = l(:label_reply_added)
redirect_to :action => 'show', :id => @topic
end
Files
Updated by Go MAEDA almost 7 years ago
- File 2635-show-notice-on-forum-updates.diff 2635-show-notice-on-forum-updates.diff added
- Assignee deleted (
Jean-Philippe Lang) - Target version set to 4.0.1
- % Done changed from 50 to 0
+1
I think the notices will improve usability. The attached patch adds notices on create/update/delete operation on forum messages.
Updated by Go MAEDA almost 7 years ago
- Status changed from New to Resolved
- Assignee set to Go MAEDA
- Estimated time deleted (
0.20 h)
Committed.
Updated by Go MAEDA almost 7 years ago
- Subject changed from Display notice on forum thread or reply creation to Display notice on forum updates
Actions