Defect #26564

Enumerations sorting does not work

Added by Sergey Gnuskov 5 months ago. Updated 5 months ago.

Status:ClosedStart date:
Priority:UrgentDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Administration
Target version:3.4.3
Resolution:Fixed Affected version:3.4.2

Description

When drag/drop enumerations, it makes successful request to server, but position does not change after page reload. The problem is that position attribute is not added to permitted params in enumerations controller, so it's skipped.

patch.diff Magnifier (565 Bytes) Sergey Gnuskov, 2017-07-28 10:56

issue-26564-test-v2.diff Magnifier (894 Bytes) Toshi MARUYAMA, 2017-07-30 06:29

Associated revisions

Revision 16918
Added by Jean-Philippe Lang 5 months ago

Fixed that Enumerations sorting is broken (#26564).

Patch by Sergey Gnuskov.

Revision 16919
Added by Jean-Philippe Lang 5 months ago

Adds a test for #26564.

Patch by Toshi MARUYAMA.

History

#1 Updated by Sergey Gnuskov 5 months ago

The patch is something like this: patch.diff.

#2 Updated by Go MAEDA 5 months ago

  • Status changed from New to Confirmed
  • Target version set to 3.4.3

Confirmed the problem. Setting target version to 3.4.3.

#3 Updated by Toshi MARUYAMA 5 months ago

  • File issue-26564-test.diff added

This is test.

#4 Updated by Toshi MARUYAMA 5 months ago

Simplified.

#5 Updated by Toshi MARUYAMA 5 months ago

  • File deleted (issue-26564-test.diff)

#6 Updated by Go MAEDA 5 months ago

  • Priority changed from Normal to Urgent

#7 Updated by Jean-Philippe Lang 5 months ago

  • Status changed from Confirmed to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Fix and test committed, thanks.

Also available in: Atom PDF