Project

General

Profile

Actions

Defect #26645

closed

git 2.14 compatibility

Added by Philip Taffner over 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

There is no "--no-color" argument for "git version" anymore.

Potential fix:

Index: lib/redmine/scm/adapters/git_adapter.rb
===================================================================
--- lib/redmine/scm/adapters/git_adapter.rb     (revision 16828)
+++ lib/redmine/scm/adapters/git_adapter.rb     (working copy)
@@ -54,7 +54,7 @@
           end

           def scm_version_from_command_line
-            shellout("#{sq_bin} --version --no-color") { |io| io.read }.to_s
+            shellout("#{sq_bin} --version") { |io| io.read }.to_s
           end
         end

Related issues

Related to Redmine - Defect #5324: Git not working if color.ui is enabledClosedJean-Baptiste Barth2010-04-15

Actions
Related to Redmine - Defect #29416: Do not show Git revisions ReopenedAlexandr Kirilov

Actions
Has duplicate Redmine - Defect #26765: Redmine 3.3.3.stable Cannot find binary for Git 2.14 Closed

Actions
Actions #1

Updated by Toshi MARUYAMA over 7 years ago

  • Related to Defect #5324: Git not working if color.ui is enabled added
Actions #2

Updated by Toshi MARUYAMA over 7 years ago

$ ./git --version
git version 2.14.0
$ ./git --version --no-color
error: unknown option `no-color'
usage: git version [<options>]

    --build-options       also print build options

$ ./git log --no-color | wc
 753470 3494163 28722346
$ ./git log | wc
 753470 3494163 28722346
$ ./git config -l | grep color
color.ui=true
Actions #3

Updated by Toshi MARUYAMA over 7 years ago

  • Subject changed from git 2.14 breaks fetch_changesets to git 2.14 comatibility
Actions #4

Updated by Toshi MARUYAMA over 7 years ago

  • Subject changed from git 2.14 comatibility to git 2.14 compatibility
Actions #5

Updated by Toshi MARUYAMA over 7 years ago

  • Target version set to 3.3.5

I have committed r16948.
We cannot use self.superclass.client_version_above? because "git --version --no-color" fails.
I think I added "--no-color" to "git --version" at r4885 for preventing feature brokenness.

Actions #6

Updated by Toshi MARUYAMA about 7 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Committed in turnk, 3.4-stable, and 3.3-stable.

Actions #7

Updated by Marius BĂLTEANU about 7 years ago

  • Has duplicate Defect #26765: Redmine 3.3.3.stable Cannot find binary for Git 2.14 added
Actions #8

Updated by Marius BĂLTEANU about 6 years ago

Actions

Also available in: Atom PDF