Defect #26645
git 2.14 compatibility
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | SCM | |||
| Target version: | 3.3.5 | |||
| Resolution: | Fixed | Affected version: | 3.4.2 |
Description
There is no "--no-color" argument for "git version" anymore.
Potential fix:
Index: lib/redmine/scm/adapters/git_adapter.rb
===================================================================
--- lib/redmine/scm/adapters/git_adapter.rb (revision 16828)
+++ lib/redmine/scm/adapters/git_adapter.rb (working copy)
@@ -54,7 +54,7 @@
end
def scm_version_from_command_line
- shellout("#{sq_bin} --version --no-color") { |io| io.read }.to_s
+ shellout("#{sq_bin} --version") { |io| io.read }.to_s
end
end
Related issues
Associated revisions
git: remove "--no-color" option from "git --version" for git 2.14 compatibility (#26645)
History
#1
Updated by Toshi MARUYAMA almost 2 years ago
- Related to Defect #5324: Git not working if color.ui is enabled added
#2
Updated by Toshi MARUYAMA almost 2 years ago
$ ./git --version
git version 2.14.0
$ ./git --version --no-color
error: unknown option `no-color'
usage: git version [<options>]
--build-options also print build options
$ ./git log --no-color | wc
753470 3494163 28722346
$ ./git log | wc
753470 3494163 28722346
$ ./git config -l | grep color
color.ui=true
#3
Updated by Toshi MARUYAMA almost 2 years ago
- Subject changed from git 2.14 breaks fetch_changesets to git 2.14 comatibility
#4
Updated by Toshi MARUYAMA almost 2 years ago
- Subject changed from git 2.14 comatibility to git 2.14 compatibility
#5
Updated by Toshi MARUYAMA almost 2 years ago
- Target version set to 3.3.5
#6
Updated by Toshi MARUYAMA almost 2 years ago
- Status changed from New to Closed
- Resolution set to Fixed
Committed in turnk, 3.4-stable, and 3.3-stable.
#7
Updated by Marius BALTEANU almost 2 years ago
- Duplicated by Defect #26765: Redmine 3.3.3.stable Cannot find binary for Git 2.14 added
#8
Updated by Marius BALTEANU 11 months ago
- Related to Defect #29416: Do not show Git revisions added