Patch #26728
count > 0 vs exists?
Status: | Closed | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | - | % Done: | 0% | |
Category: | Code cleanup/refactoring | |||
Target version: | - |
Description
redmine/app/models/project.rb:671: if versions.count > 0 redmine/app/views/imports/show.html.erb:3:<% if @import.saved_items.count > 0 %> redmine/app/views/imports/show.html.erb:15:<% if @import.unsaved_items.count > 0 %>
could be
redmine/app/models/project.rb:671: if versions.exists? redmine/app/views/imports/show.html.erb:3:<% if @import.saved_items.exists? %> redmine/app/views/imports/show.html.erb:15:<% if @import.unsaved_items.exists?%>
Related issues
History
#1
Updated by Toshi MARUYAMA almost 5 years ago
- Category set to Code cleanup/refactoring
- Status changed from New to Needs feedback
Please post by patch.
#2
Updated by Toshi MARUYAMA almost 5 years ago
And please describe why this change is effective.
#3
Updated by Toshi MARUYAMA almost 5 years ago
Toshi MARUYAMA wrote:
Please post by patch.
Please post by attachment patch file.
#4
Updated by Go MAEDA about 4 years ago
- Related to Patch #24839: Minor performance improvement - Replace count by exists? added
#5
Updated by Go MAEDA about 4 years ago
- Status changed from Needs feedback to Closed
We have decided not to use exists?
there. Please see #24839#note-1 and #24839#note-3.