Project

General

Profile

Actions
Copy link

Defect #2754

closed

Setting up the default_url_options :port in hook will duplicate with the host parameter(which already contains port param) in settings

Added by Chaoqun Zou about 17 years ago. Updated about 17 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Eric Davis
Category:
Plugin API
Target version:
-
Resolution:
Cant reproduce
Affected version:

Description

By r2429, the plugin hook will setting up the default_url_options :host, :port, and :protocol.

But in the setting page, the host parameter is designed to contain port, so the two port will duplicated. Now I can see them duplicated in mails.

For example:

  • Send test mail in the setting page
  • The issue' url in the notification mail

Files

Download all files
http.txt (2.54 KB) http.txt Email with protocol set to http, no isssue Eric Davis, 2009-02-21 00:11
https.txt (2.55 KB) https.txt Email with protocol set to https, no isssue Eric Davis, 2009-02-21 00:11

Related issues

Related to Redmine - Feature #2542: Plugin hooks should have access to the "request" variableClosedEric Davis2009-01-19Actions
Actions
Copy link
 #1

Updated by Jean-Philippe Lang about 17 years ago

  • Assignee set to Eric Davis
Actions
Copy link
 #2

Updated by Eric Davis about 17 years ago

Chaoqun Zou, I'm not see this bug at all. Can you attach the source emails and what values you have in your "Host name and path" and "Protocol"?

Attached my own testing results.

Actions
Copy link
 #3

Updated by Eric Davis about 17 years ago

  • Status changed from New to Closed

I did some refactoring to this area of code in r2489, r2490, and r2491 so this should be resolved. Please reopen the issue if you can provide some sample emails for me to reproduce.

Actions
Copy link

Also available in: Atom PDF