Defect #27780
Attachment sort doesn't work with Unicode
| Status: | New | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | Attachments | |||
| Target version: | Candidate for next major release | |||
| Resolution: | Affected version: |
Description
casecmp method doesn't work with Unicode symbol - https://bugs.ruby-lang.org/issues/14055
decision is to use casecmp? instead of casecmp - https://bugs.ruby-lang.org/issues/12786
attachment.rb.patch 
(404 Bytes)
Related issues
History
#1
Updated by Toshi MARUYAMA about 1 year ago
- Tracker changed from Patch to Defect
- Subject changed from Attachment.rb patch to Attachment sort doesn't work with Unicode
#2
Updated by Toshi MARUYAMA about 1 year ago
Could you add test?
source:trunk/test/unit/attachment_test.rb@17111#L386
#3
Updated by Go MAEDA about 1 year ago
Амир Мусин, thank you for reporting the problem and providing the patch.
But the patch needs some improvements because Ruby older than 2.4 don't have casecmp? (https://github.com/ruby/ruby/blob/v2_4_0/NEWS). The upcoming Redmine 4.0.0 supports Ruby 2.2.2 and later (#25538).
#4
Updated by Go MAEDA about 1 year ago
- Related to Patch #20369: Use String#casecmp for case insensitive comparison added
#5
Updated by Go MAEDA about 1 month ago
- Target version set to Candidate for next major release
We can merge this patch if Redmine migrates to Rails 6 (maybe in Redmine 5?).
Rails 6 requires Ruby 2.4.1+ by jeremy · Pull Request #32034 · rails/rails
#6
Updated by Go MAEDA about 1 month ago
- Related to Feature #29914: Migrate to Rails 6 added