Patch #29614

redmine:email:read and rdm-mailhandler.rb should use safe_receive instead of receive

Added by Go MAEDA about 1 month ago. Updated 23 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Email receiving
Target version:4.0.0

Description

Since r12995, rake redmine:email:receive_imap and rake redmine:email:receive_pop3 use MailHandler.safe_receive instead of receive to handle exceptions which raised while processing broken email. However, rake redmine:email:read and MailHandlerController#index (invoked from rdm-mailhandler.rb) still uses receive method, not safe_receive method.

I think rake redmine:email:read and MailHandlerController#index should also use safe_receive method instead of receive method to handle exceptions in a same way with receive_imap and receive_pop3.

replace-receive-with-safe_receive.diff Magnifier (964 Bytes) Go MAEDA, 2018-09-15 07:04


Related issues

Related to Redmine - Defect #16122: redmine:email:receive should not abort with buggy mail New

Associated revisions

Revision 17508
Added by Jean-Philippe Lang 23 days ago

redmine:email:read and rdm-mailhandler.rb should use safe_receive instead of receive (#29614).

Patch by Go MAEDA.

History

#1 Updated by Go MAEDA about 1 month ago

  • Related to Defect #16122: redmine:email:receive should not abort with buggy mail added

#2 Updated by Go MAEDA about 1 month ago

  • Target version set to 4.0.0

#3 Updated by Jean-Philippe Lang 23 days ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks.

Also available in: Atom PDF