Patch #30026

macros and textile at pdf export in custom field

Added by Dirk Rudolph 6 months ago. Updated 21 days ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:PDF export
Target version:Candidate for next major release

Description

Redmine in version 3.4.6 don't fully support textile and macros in pdf export/print when custom fields be used formatted text.
I did some changes in the issue_pdf_helper.rb to do that.

issues_pdf_helper-redmine-3.4.6.rb.patch Magnifier (4.71 KB) Dirk Rudolph, 2018-11-24 22:53

issues_pdf_helper-redmine-3.4.6.rb.patch Magnifier (4.71 KB) Dirk Rudolph, 2018-11-25 01:04

issues_pdf_helper-redmine-3.4.6_2sec_version.rb Magnifier (22.9 KB) Dirk Rudolph, 2018-11-25 01:08

table-breaks-layout.pdf (95.5 KB) Go MAEDA, 2018-11-25 05:29

issues_pdf_helper.rb-redmine-3.4.6_3rd.patch Magnifier (5.41 KB) Dirk Rudolph, 2018-11-25 14:14

issues_pdf_helper.rb-redmine-3.4.6_4th.patch Magnifier (5.68 KB) Dirk Rudolph, 2018-11-25 16:38

History

#2 Updated by Dirk Rudolph 6 months ago

little optimizations

#3 Updated by Go MAEDA 6 months ago

Thank you for the patch. But I noticed the following points:

  • The values should be textilized only when the text_formatting attribute for the custom field is true. The patch always textilizes the value
  • Inserting a table breaks the layout. Please see the attached pdf (table-breaks-layout.pdf). Blank lines are inserted after the table

#4 Updated by Dirk Rudolph 6 months ago

Go MAEDA wrote:

  • The values should be textilized only when the text_formatting attribute for the custom field is true. The patch always textilizes the value

No, the used function show_value() seems to check that. I tried out.

  • Inserting a table breaks the layout. Please see the attached pdf (table-breaks-layout.pdf). Blank lines are inserted after the table

Yes is true. The table cell becomes bigger because the height is calculated over html code in the backround. I think it's better to have a big cell and the content fits into, instead a cell that's to small. But I will trie to optimize.

#5 Updated by Dirk Rudolph 6 months ago

Some optimizations for the layout.
For the cell height calculation, some html-strings will remove.

#6 Updated by Dirk Rudolph 6 months ago

Further optimizations for issues list ...

#7 Updated by Go MAEDA 21 days ago

  • Target version set to Candidate for next major release

Also available in: Atom PDF