Actions
Defect #30256
closedCannot make cross-project wiki link if the project name includes square brackets
Defect #30256:
Cannot make cross-project wiki link if the project name includes square brackets
Resolution:
Fixed
Affected version:
Description
According to the Wiki formatting help, You can link to wiki pages of another project using the following syntax.
However, it does not work if the name of the destination project includes "[" or "]" character.
For example, suppose that there is a project named "[Foo]Bar". If you want to link to wiki pages in the project, the syntax is "[[[Foo]Bar:PageName]]". However, it does not generate any link.

Files
Updated by Go MAEDA almost 8 years ago
- Related to Defect #20397: project:someproject wiki syntax should link to project with identifier "someproject', not name. added
Updated by Yuichi HARADA almost 8 years ago
- File 30256-make-wiki-link-includes-brackets.patch 30256-make-wiki-link-includes-brackets.patch added
I reviewed the regular expression as follows.(Change from "greedy quantifier" to "lazy quantifier")
https://ruby-doc.org/core-2.6/doc/regexp_rdoc.html#label-Repetition
I attached a patch.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index e250c20ee..8fa56ac55 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -787,7 +787,7 @@ module ApplicationHelper
# [[project:mypage]]
# [[project:mypage|mytext]]
def parse_wiki_links(text, project, obj, attr, only_path, options)
- text.gsub!(/(!)?(\[\[([^\]\n\|]+)(\|([^\]\n\|]+))?\]\])/) do |m|
+ text.gsub!(/(!)?(\[\[([^\n\|]+?)(\|([^\n\|]+?))?\]\])/) do |m|
link_project = project
esc, all, page, title = $1, $2, $3, $5
if esc.nil?
Updated by Go MAEDA almost 8 years ago
- Target version set to Candidate for next minor release
Updated by Go MAEDA over 7 years ago
- Target version changed from Candidate for next minor release to 4.0.3
LGTM. Setting the target version to 4.0.3.
Updated by Go MAEDA over 7 years ago
- Subject changed from Cannot make cross-project wiki link if the project name includes "[" or "]" to Cannot make cross-project wiki link if the project name includes square brackets
- Status changed from New to Resolved
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you for your contribution.
Updated by Go MAEDA over 7 years ago
- Status changed from Resolved to Closed
Actions