Defect #30426
closed
Table rows are not highlighted on mouseover on some pages
0%
Description
I am testing redmine v4.0.0 and discovered that hovering on some pages does not work.
Till now I discovered that problem on:
- .../projects/ProjectName/settings/activities
- .../admin/projects
- .../users
- .../groups
- .../roles
- .../trackers
and so on....
With hovering I mean: when mouse pointer is over some row on table, whole row is highlited (yellow like in version e.g 2.3).
Without hovering, it is realy difficult to not to make mistake while selecting action on far right on that row, while row label is on the far left.
Files
Updated by Go MAEDA over 5 years ago
- Status changed from New to Confirmed
- Target version set to Candidate for next minor release
- Affected version changed from 4.0.0 to 3.4.7
Confirmed the problem in 3.4.7 and 4.0.0. No problem was found in 3.3.9.
Updated by Marius BĂLTEANU over 5 years ago
- Target version changed from Candidate for next minor release to 3.4.8
The fix is quite simple:
diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index fa59d6a..80defce 100644
--- a/public/stylesheets/application.css
+++ b/public/stylesheets/application.css
@@ -352,13 +352,13 @@ tr.group a.toggle-all { color: #aaa; font-size: 80%; display:none; float:right;
tr.group:hover a.toggle-all { display:inline;}
a.toggle-all:hover {text-decoration:none;}
-table.list tbody tr:hover { background-color:#ffffdd; }
-table.list tbody tr.group:hover { background-color:inherit; }
table td {padding:2px;}
table p {margin:0;}
table.list:not(.odd-even) tbody tr:nth-child(odd), .odd, #issue-changesets div.changeset:nth-child(odd) { background-color:#f6f7f8; }
table.list:not(.odd-even) tbody tr:nth-child(even), .even, #issue-changesets div.changeset:nth-child(even) { background-color: #fff; }
+table.list tbody tr:hover { background-color:#ffffdd !important; }
+table.list tbody tr.group:hover { background-color:inherit !important; }
tr.builtin td.name {font-style:italic;}
Even if I'm not a fan of "!important", I think that in this case it is ok to use it.
Updated by VD DV over 5 years ago
Is same fix applicable to v4.0.0? If not, can you provide fixed file (I assume it is only application.css), to upload to v4.0.0 redmine installation?
Updated by Marius BĂLTEANU over 5 years ago
VD DV wrote:
Is same fix applicable to v4.0.0? If not, can you provide fixed file (I assume it is only application.css), to upload to v4.0.0 redmine installation?
Yes, it is.
Updated by Go MAEDA over 5 years ago
- Subject changed from Hovering on most pages does not work as before to Table rows are not highlighted on mouseover on some pages
Updated by Go MAEDA over 5 years ago
- Status changed from Confirmed to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you all for reporting and fixing this issue.
VD DV wrote:
Is same fix applicable to v4.0.0? If not, can you provide fixed file (I assume it is only application.css), to upload to v4.0.0 redmine installation?
Please replace application.css with https://www.redmine.org/projects/redmine/repository/revisions/17801/raw/branches/4.0-stable/public/stylesheets/application.css.
Updated by Go MAEDA over 5 years ago
- File undesirable-highlighting-in-issues-list@2x.png undesirable-highlighting-in-issues-list@2x.png added
- Status changed from Closed to Reopened
The change r17800 caused undesirable behavior in the issues list. Multiple selected issues are also highlighted on mouseover, so you can not read the text.
I will revert the change.
Updated by Marius BĂLTEANU over 5 years ago
Go MAEDA wrote:
The change r17800 caused undesirable behavior in the issues list. Multiple selected issues are also highlighted on mouseover, so you can not read the text.
I will revert the change.
Sorry, I’ll rewrite the fix.
Updated by Marius BĂLTEANU over 5 years ago
- File fix_30426.patch fix_30426.patch added
Attached a better fix. I've checked both scenarios and it works well.
Sorry for my previous fix and a note to myself: "!important is never safe"
Updated by Go MAEDA over 5 years ago
- Status changed from Reopened to Resolved
Marius BALTEANU wrote:
Attached a better fix. I've checked both scenarios and it works well.
Committed. Thanks!
a note to myself: "!important is never safe"
I must not forget this, too.