Project

General

Profile

Actions
Copy link

Defect #30431

closed

Useless "Delete issues" tracker permission is shown on the role page for Anonymous and Non-member

Added by Go MAEDA almost 7 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Permissions and roles
Target version:
4.1.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Since you cannot grant a "Delete issues" permission for Anonymous and Non-member roles, "Delete issues" column in the tracker permission table on the role page is useless. The column should be hidden like default "Reporter" role.

Files

Download all files
delete-issues-tracker-permission@2x.png (17.8 KB) delete-issues-tracker-permission@2x.png Go MAEDA, 2019-01-15 07:03
30431.patch (2.5 KB) 30431.patch Yuichi HARADA, 2019-04-26 06:57
30431-v2.patch (1.21 KB) 30431-v2.patch Go MAEDA, 2019-09-22 07:31
Actions
Copy link
 #1

Updated by Yuichi HARADA over 6 years ago

It was displayed "Delete issues" column in the tracker permission table on the role page because it was not confirmed the settable permissions of the role.
I attached a patch.

Actions
Copy link
 #2

Updated by Go MAEDA over 6 years ago

  • Target version set to Candidate for next minor release
Actions
Copy link
 #3

Updated by Go MAEDA about 6 years ago

LGTM but I propose a slight change as follows. Using & operator is simpler and much faster than using delete_if.

<% permissions = [:view_issues, :add_issues, :edit_issues, :add_issue_notes, :delete_issues] & setable_permissions.collect(&:name) %>

Setting the target version to 4.1.0.

Actions
Copy link
 #4

Updated by Go MAEDA about 6 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for fixing this issue.

Actions
Copy link

Also available in: Atom PDF