Defect #30489

Internal server error when click middle mouse button link add watcher

Added by Alex Tim 29 days ago. Updated 18 days ago.

Status:ConfirmedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Issues list
Target version:Candidate for next minor release
Resolution: Affected version:

Description

Clicking middle mouse button on the add wathcer link in the context menu fails

ActionController::UnknownFormat in WatchersController#new
WatchersController#new is missing a template for this request format and variant. request.formats: ["text/html"] request.variant: []

History

#1 Updated by Marius BALTEANU 29 days ago

  • Status changed from New to Confirmed

#2 Updated by Marius BALTEANU 18 days ago

Maybe it is enough to return 404 when the request format is HTML?

diff --git a/app/controllers/watchers_controller.rb b/app/controllers/watchers_controller.rb
index 3f080e9..cec2519 100644
--- a/app/controllers/watchers_controller.rb
+++ b/app/controllers/watchers_controller.rb
@@ -30,7 +30,10 @@ class WatchersController < ApplicationController
   accept_api_auth :create, :destroy

   def new
-    @users = users_for_new_watcher
+    respond_to do |format|
+      format.html { render_404 }
+      format.js { @users = users_for_new_watcher }
+    end
   end

   def create

#4 Updated by Marius BALTEANU 18 days ago

  • Target version set to Candidate for next minor release

#5 Updated by Go MAEDA 18 days ago

Since I use MacBook Pro and don't have a mouse with a middle button, I cannot reproduce the problem. Adding issue watchers works fine for me.

Could someone tell me how the middle button works and causes the error?

#6 Updated by Marius BALTEANU 18 days ago

Yes, middle button means Open link in new tab. To reproduce, go to an issue, right click on the Add watchers link and then Open link in a new tab. Technically, instead of an Ajax request you will do a simple get request.

#7 Updated by Go MAEDA 18 days ago

Marius BALTEANU wrote:

Yes, middle button means Open link in new tab.

Thanks, I understand. I think this issue is not a big problem, so the fix that simply returns 404 is enough.

I found that this issue also affects the following links.

  • "Watch" link
  • "Search for watchers to add" link on "New issue" page

Also available in: Atom PDF