Patch #30971

principals_options_for_select does not select user when user id is numeric

Added by Jérôme BATAILLE over 3 years ago. Updated over 3 years ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Issues
Target version:-

Description

To fix it : In application Helper L487
convert selected to string if it is an integer

if selected.is_a?(Integer)
  selected_s = selected.to_s
else
  selected_s = selected
end
selected_attribute = ' selected="selected"' if option_value_selected?(element, selected) || element.id.to_s == selected_s

History

#1 Updated by Go MAEDA over 3 years ago

Could you show the steps to reproduce the problem with the Web UI?

#2 Updated by Jérôme BATAILLE over 3 years ago

The only places where selected is an integer are :
  • in bulk edit :
    ->/lxc/redmine4/home/smile/redmine-4.0.0/app/views/issues/bulk_edit.html.erb
    74: principals_options_for_select(@assignables, @issue_params[:assigned_to_id])) %>
    NOT sure if @issue_params[:assigned_to_id]) is passed as a string or an integer
  • and in Redmine V4.1 :
    in timelog_helper : user_collection_for_select_options

Also available in: Atom PDF