Defect #31021
open
Fullwidth characters enclosed in "<" and ">" are removed in email notifications
0%
Description
Hi, I'm using Redmine ver.3.4.7 and multi-byte environment(Japanese).
I found a bug in mail notifications function.
When I update a ticket with the comments below
-----
aaa<bbb>ccc
ＡＡＡ<ＢＢＢ>ＣＣＣ
-----
The less-than sign, grater-than sign, and multi-byte "BBB" are deleted in the mail, while the ticket itself is properly updated.
Note that the first sentence is written using single-byte characters, and the second one is written using multi-byte characters except less-than sign(<) and grater-than sign(>).
It will not happen when the letters are quoted with < pre > and < /pre >.
Neither It will not happen when html mail is not used.
See the attached for details.
Files
Updated by Go MAEDA over 6 years ago
- File email-4.png email-4.png added
I cannot reproduce the problem in the current trunk (Redmine 4.0.2.devel.17938). I will check with 3.4 later.
Updated by Masaomi Yoshida over 6 years ago
Maeda-san,
Thanks for prompt response and trying to reproduce.
I forgot saying this but if characters are all single-byte in < and >, the bug will not happen.
It happens only when the characters include multi-byte characters.
Please try using my sample in description section.
aaa<bbb>ccc ＡＡＡ<ＢＢＢ>ＣＣＣ
Updated by Go MAEDA over 6 years ago
- Status changed from New to Confirmed
Masaomi Yoshida wrote:
It happens only when the characters include multi-byte characters.
Thank you for pointing it out. I have confirmed that the issue is reproducible in the current trunk.
Updated by Go MAEDA over 6 years ago
- Subject changed from Letters/Words are deleted in mails when multi-byte characters are in less-than sign(<) and grater-than sign(>) to Fullwidth characters enclosed in "<" and ">" are removed in email notifications
Updated by Yuichi HARADA over 6 years ago
- File 0001-Remove-unnecessary-trailing-white-spaces.patch 0001-Remove-unnecessary-trailing-white-spaces.patch added
- File 0002-Fullwidth-characters-enclosed-in-lt-and-gt.patch 0002-Fullwidth-characters-enclosed-in-lt-and-gt.patch added
- File 0003-Add-tests.patch 0003-Add-tests.patch added
Escape processing of "<" and ">" is performed by RedCloth3#escape_html_tags .
source:/trunk/lib/redmine/wiki_formatting/textile/redcloth3.rb#L1218
However, full-width characters could not be processed because they do not match the regular expression "\w".
Change the regular expression "\w" to "_" and "[[:alnum:]]" to match even full-width characters.
I attached the patches.
Updated by Go MAEDA over 6 years ago
- Target version set to Candidate for next minor release
Updated by Go MAEDA over 6 years ago
I tested the patch and found that the problem still remains for strings such as "<###>" and "<あいうえお>".
Updated by Go MAEDA over 6 years ago
- Target version deleted (
Candidate for next minor release)