Patch #31046

Remove unused method ApplicationHelper#generate_csv

Added by Go MAEDA 4 months ago. Updated 4 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:4.1.0

Description

ApplicationHelper#generate_csv was added in r14302, but the method has never been used and seems to be doing nothing useful.

Index: app/helpers/application_helper.rb
===================================================================
--- app/helpers/application_helper.rb    (リビジョン 17987)
+++ app/helpers/application_helper.rb    (作業コピー)
@@ -1567,11 +1567,6 @@
     end
   end

-  def generate_csv(&block)
-    decimal_separator = l(:general_csv_decimal_separator)
-    encoding = l(:general_csv_encoding)
-  end
-
   def export_csv_encoding_select_tag
     return if l(:general_csv_encoding).casecmp('UTF-8') == 0
     options = [l(:general_csv_encoding), 'UTF-8']

Associated revisions

Revision 17989
Added by Go MAEDA 4 months ago

Remove unused method ApplicationHelper#generate_csv (#31046).

Patch by Go MAEDA.

History

#1 Updated by Go MAEDA 4 months ago

  • Target version changed from Candidate for next minor release to 4.1.0

#2 Updated by Go MAEDA 4 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed.

Also available in: Atom PDF