Project

General

Profile

Actions

Defect #31496

closed

Switch between toggle plus and minus icons for toggle multi select

Added by Marius BĂLTEANU almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

This patch:
  1. fixes the existent behaviour where the same toggle plus icon is shown regardless multi select state
  2. adds the "icon icon-*" classes

Before:

After:


Files

0001-Icon-classes-for-toggle-select.patch (5.32 KB) 0001-Icon-classes-for-toggle-select.patch Marius BĂLTEANU, 2019-06-02 10:33
before.png (49.1 KB) before.png Marius BĂLTEANU, 2019-06-02 10:35
after.png (56.2 KB) after.png Marius BĂLTEANU, 2019-06-02 10:36
fix_toggle-multiselect.patch (3.11 KB) fix_toggle-multiselect.patch Marius BĂLTEANU, 2019-06-03 08:50

Related issues

Related to Redmine - Feature #31328: Change the "+" button in the issues filter to a larger oneClosedGo MAEDA

Actions
Related to Redmine - Patch #31433: Use "icon icon-*" classes for sort-handler, collapsible fieldsets and collapsible versionsClosedGo MAEDA

Actions
Related to Redmine - Defect #31502: Error syntax in application.cssClosed

Actions
Actions #1

Updated by Go MAEDA almost 5 years ago

  • Related to Feature #31328: Change the "+" button in the issues filter to a larger one added
Actions #2

Updated by Go MAEDA almost 5 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version changed from Candidate for next major release to 4.1.0
  • Resolution set to Fixed

Committed the patch. Thank you for fixing the behavior.

Actions #3

Updated by Marius BĂLTEANU almost 5 years ago

  • Related to Patch #31433: Use "icon icon-*" classes for sort-handler, collapsible fieldsets and collapsible versions added
Actions #4

Updated by Go MAEDA almost 5 years ago

  • Related to Defect #31502: Error syntax in application.css added
Actions #5

Updated by Go MAEDA almost 5 years ago

  • Status changed from Closed to Resolved

An error in application.css was reported as #31502.

Actions #6

Updated by Go MAEDA almost 5 years ago

  • Status changed from Resolved to Reopened
Actions #7

Updated by Marius BĂLTEANU almost 5 years ago

Please commit the attached fixes, the problem wasn't only the broken css rule.

Actions #8

Updated by Marius BĂLTEANU almost 5 years ago

My last patch fixes:
- incorrect icon-toggle-plus and icon-toggle-minus background rules
- broken CSS rule in .toggle-multiselect and removes some unnecessary rules
- some cases where clicking on toggle-multiselect element adds the icon class to "a" element instead of "span"
- icon switch in workflow permissions tab.

Actions #9

Updated by Go MAEDA almost 5 years ago

  • Status changed from Reopened to Closed

Marius BALTEANU wrote:

Please commit the attached fixes, the problem wasn't only the broken css rule.

Committed in r18224. Thanks.

Actions

Also available in: Atom PDF