Defect #31496
Switch between toggle plus and minus icons for toggle multi select
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | UI | |||
| Target version: | 4.1.0 | |||
| Resolution: | Fixed | Affected version: |
Description
- fixes the existent behaviour where the same toggle plus icon is shown regardless multi select state
- adds the "icon icon-*" classes
Before:
After:
0001-Icon-classes-for-toggle-select.patch 
(5.32 KB)
before.png (49.1 KB)
after.png (56.2 KB)
fix_toggle-multiselect.patch
(3.11 KB)
Related issues
Associated revisions
Switch between toggle plus and minus icons for toggle multi select (#31496).
Patch by Marius BALTEANU.
Some fixes for r18214 (#31496):
- incorrect icon-toggle-plus and icon-toggle-minus background rules
- broken CSS rule in .toggle-multiselect and removes some unnecessary rules
- some cases where clicking on toggle-multiselect element adds the icon class to "a" element instead of "span"
- icon switch in workflow permissions tab
Patch by Marius BALTEANU.
History
#1
Updated by Go MAEDA over 3 years ago
- Related to Feature #31328: Change the "+" button in the issues filter to a larger one added
#2
Updated by Go MAEDA over 3 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Target version changed from Candidate for next major release to 4.1.0
- Resolution set to Fixed
Committed the patch. Thank you for fixing the behavior.
#3
Updated by Marius BALTEANU over 3 years ago
- Related to Patch #31433: Use "icon icon-*" classes for sort-handler, collapsible fieldsets and collapsible versions added
#4
Updated by Go MAEDA over 3 years ago
- Related to Defect #31502: Error syntax in application.css added
#5
Updated by Go MAEDA over 3 years ago
- Status changed from Closed to Resolved
An error in application.css was reported as #31502.
#6
Updated by Go MAEDA over 3 years ago
- Status changed from Resolved to Reopened
#7
Updated by Marius BALTEANU over 3 years ago
- File fix_toggle-multiselect.patch added
Please commit the attached fixes, the problem wasn't only the broken css rule.
#8
Updated by Marius BALTEANU over 3 years ago
My last patch fixes:
- incorrect icon-toggle-plus and icon-toggle-minus background rules
- broken CSS rule in .toggle-multiselect and removes some unnecessary rules
- some cases where clicking on toggle-multiselect element adds the icon class to "a" element instead of "span"
- icon switch in workflow permissions tab.
#9
Updated by Go MAEDA over 3 years ago
- Status changed from Reopened to Closed
Marius BALTEANU wrote:
Please commit the attached fixes, the problem wasn't only the broken css rule.
Committed in r18224. Thanks.