Defect #31496

Switch between toggle plus and minus icons for toggle multi select

Added by Marius BALTEANU 24 days ago. Updated 22 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI
Target version:4.1.0
Resolution:Fixed Affected version:

Description

This patch:
  1. fixes the existent behaviour where the same toggle plus icon is shown regardless multi select state
  2. adds the "icon icon-*" classes

Before:

After:

0001-Icon-classes-for-toggle-select.patch Magnifier (5.32 KB) Marius BALTEANU, 2019-06-02 10:33

before.png (49.1 KB) Marius BALTEANU, 2019-06-02 10:35

after.png (56.2 KB) Marius BALTEANU, 2019-06-02 10:36

fix_toggle-multiselect.patch Magnifier (3.11 KB) Marius BALTEANU, 2019-06-03 08:50


Related issues

Related to Redmine - Feature #31328: Change the "+" button in the issues filter to a larger one Closed
Related to Redmine - Patch #31433: Use "icon icon-*" classes for sort-handler, collapsible f... Closed
Related to Redmine - Defect #31502: Error syntax in application.css Closed

Associated revisions

Revision 18214
Added by Go MAEDA 24 days ago

Switch between toggle plus and minus icons for toggle multi select (#31496).

Patch by Marius BALTEANU.

Revision 18224
Added by Go MAEDA 22 days ago

Some fixes for r18214 (#31496):

  • incorrect icon-toggle-plus and icon-toggle-minus background rules
  • broken CSS rule in .toggle-multiselect and removes some unnecessary rules
  • some cases where clicking on toggle-multiselect element adds the icon class to "a" element instead of "span"
  • icon switch in workflow permissions tab

Patch by Marius BALTEANU.

History

#1 Updated by Go MAEDA 24 days ago

  • Related to Feature #31328: Change the "+" button in the issues filter to a larger one added

#2 Updated by Go MAEDA 24 days ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version changed from Candidate for next major release to 4.1.0
  • Resolution set to Fixed

Committed the patch. Thank you for fixing the behavior.

#3 Updated by Marius BALTEANU 24 days ago

  • Related to Patch #31433: Use "icon icon-*" classes for sort-handler, collapsible fieldsets and collapsible versions added

#4 Updated by Go MAEDA 23 days ago

  • Related to Defect #31502: Error syntax in application.css added

#5 Updated by Go MAEDA 23 days ago

  • Status changed from Closed to Resolved

An error in application.css was reported as #31502.

#6 Updated by Go MAEDA 23 days ago

  • Status changed from Resolved to Reopened

#7 Updated by Marius BALTEANU 23 days ago

Please commit the attached fixes, the problem wasn't only the broken css rule.

#8 Updated by Marius BALTEANU 22 days ago

My last patch fixes:
- incorrect icon-toggle-plus and icon-toggle-minus background rules
- broken CSS rule in .toggle-multiselect and removes some unnecessary rules
- some cases where clicking on toggle-multiselect element adds the icon class to "a" element instead of "span"
- icon switch in workflow permissions tab.

#9 Updated by Go MAEDA 22 days ago

  • Status changed from Reopened to Closed

Marius BALTEANU wrote:

Please commit the attached fixes, the problem wasn't only the broken css rule.

Committed in r18224. Thanks.

Also available in: Atom PDF