Patch #31556

Update Rouge to 3.5.1

Added by Marius BALTEANU 14 days ago. Updated about 3 hours ago.

Status:ReopenedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Gems support
Target version:4.1.0

0001-Update-rouge-to-3.4.0.patch Magnifier (602 Bytes) Marius BALTEANU, 2019-06-12 08:20

0001-Update-rouge-to-3.4.1.patch Magnifier (602 Bytes) Marius BALTEANU, 2019-06-13 09:07

31556-update-test.patch Magnifier (1004 Bytes) Go MAEDA, 2019-06-13 09:19

Associated revisions

Revision 18258
Added by Go MAEDA 10 days ago

Update Rouge to 3.4.1 (#31556).

Patch by Marius BALTEANU and Go MAEDA.

History

#2 Updated by Marius BALTEANU 13 days ago

#3 Updated by Go MAEDA 13 days ago

This is due to the change https://github.com/rouge-ruby/rouge/pull/1165/. Rouge changed the CSS class for quotation marks in 3.4.0, so we can simply update the test.

By the way, how about delivering this in 4.1.0 instead of 4.2.0?

#4 Updated by Marius BALTEANU 13 days ago

Go MAEDA wrote:

This is due to the change https://github.com/rouge-ruby/rouge/pull/1165/. Rouge changed the CSS class for quotation marks in 3.4.0, so we can simply update the test.

By the way, how about delivering this in 4.1.0 instead of 4.2.0?

Now that 3.4.1 is out with a hot fix, I think it is safe.

#5 Updated by Go MAEDA 13 days ago

  • Target version changed from 4.2.0 to 4.1.0

Setting the target version to 4.1.0.

#6 Updated by Go MAEDA 10 days ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thanks.

#7 Updated by Go MAEDA about 3 hours ago

  • Subject changed from Update Rouge to 3.4.1 to Update Rouge to 3.5.1
  • Status changed from Closed to Reopened

Rouge 3.5.1 has been released on July 25th.

It passed all the tests. I think we can update Rouge to 3.5.1.

diff --git a/Gemfile b/Gemfile
index ecd3bd150..4b7350e40 100644
--- a/Gemfile
+++ b/Gemfile
@@ -3,7 +3,7 @@ source 'https://rubygems.org'
 gem "bundler", ">= 1.5.0" 

 gem "rails", "5.2.3" 
-gem "rouge", "~> 3.4.1" 
+gem "rouge", "~> 3.5.1" 
 gem "request_store", "1.0.5" 
 gem "mini_mime", "~> 1.0.1" 
 gem "actionpack-xml_parser" 

Also available in: Atom PDF