'use strict' in inlineAutoComplete causes error on Poltergeist
|Assignee:||Tatsuya Saito||% Done:|
|Resolution:||Wont fix||Affected version:|
'use strict' in inlineAutoComplete causes error on Poltergeist.
r18444 with #31989 implemented inlineAutoComplete method in application.js.
After that, integration tests of my plugin have following errors.
I attach a patch to fix it.
#2 Updated by Tatsuya Saito over 2 years ago
Go MAEDA wrote:
r18444 added inlineAutoComplete method in application.js.
This method has const in use strict.
I think old browsers without supporting ES6 may have same error (sorry, I don't check them).
So I think this problem should be fixed by core code.
If that old browsers are not supported, this problem is my plugin test, so should reject this issue.
#4 Updated by Marius BALTEANU over 2 years ago
- Status changed from New to Needs feedback
- Assignee changed from Marius BALTEANU to Tatsuya Saito
I don’t think we should write old JS syntax only to make the code compatible with PhantomJS which is no longer under active development. Also, Redmine is using Selenium with Chrome driver for system tests starting with version 4.
Regarding old browsers, I would be very happy to change the code if is not compatible with an old browser which is still supported by Redmine. Do you know one? From my tests, there is no problem in IE11.