Defect #32525

CSV related tests fail with Rails 5.2.4

Added by Go MAEDA over 1 year ago. Updated about 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Rails support
Target version:-
Resolution:Fixed Affected version:

Description

22 CSV related tests fail with Rails 5.2.4.

Failure:
TimelogControllerTest#test_index_csv_all_projects [/Users/maeda/redmines/redmine-trunk/test/functional/timelog_controller_test.rb:1386]:
Expected: "text/csv" 
  Actual: "text/csv; header=present" 

bin/rails test test/functional/timelog_controller_test.rb:1382
.
.
.
diff --git a/Gemfile b/Gemfile
index ec61c6950..25da95c7e 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,7 +2,7 @@ source 'https://rubygems.org'

 gem "bundler", ">= 1.5.0" 

-gem "rails", "5.2.3" 
+gem "rails", "5.2.4" 
 gem "rouge", "~> 3.13.0" 
 gem "request_store", "1.0.5" 
 gem "mini_mime", "~> 1.0.1" 

32525.patch Magnifier (8.86 KB) Go MAEDA, 2019-11-29 16:09


Related issues

Related to Redmine - Feature #32526: Update Rails to 5.2.4.1 Closed

Associated revisions

Revision 19344
Added by Go MAEDA about 1 year ago

CSV related tests fail with Rails 5.2.4 (#32526, #32525).

Patch by Go MAEDA.

Revision 19351
Added by Go MAEDA about 1 year ago

Merged r19344 from trunk to 4.1-stable (#32526, #32525).

Revision 19353
Added by Go MAEDA about 1 year ago

Merged r19344 from trunk to 4.0-stable (#32526, #32525).

History

#1 Updated by Go MAEDA over 1 year ago

#2 Updated by Go MAEDA over 1 year ago

We changed the tests to expect the content type as "text/csv" instead of "text/csv; header=present" in r18028 in order to follow the change https://github.com/rails/rails/pull/35549, but the change in Rails was reverted by https://github.com/rails/rails/pull/35706/files.

#3 Updated by Go MAEDA over 1 year ago

The code after applying the attached patch supports both Rails 5.2.3 and Rails 5.2.4.

#4 Updated by Go MAEDA about 1 year ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed as a part of #32526.

Also available in: Atom PDF