Patch #32530

Update RuboCop to 1.12

Added by Go MAEDA over 2 years ago. Updated over 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Gems support
Target version:4.2.0

Description

The attached patch updates RuboCop to 0.77.

update-rubocop.patch Magnifier (8.18 KB) Go MAEDA, 2019-11-29 08:31

update_rubocop.patch Magnifier (663 Bytes) Marius BALTEANU, 2020-04-05 08:57

update-rubocop.patch Magnifier (22.3 KB) Go MAEDA, 2020-10-20 17:57

Related issues

Related to Redmine - Feature #34142: Drop Ruby 2.3 support Closed
Blocked by Redmine - Patch #34150: Use match? instead of =~ when MatchData is not used Closed

Associated revisions

Revision 19320
Added by Go MAEDA over 2 years ago

Update RuboCop to 0.77 (#32530).

Revision 19405
Added by Go MAEDA over 2 years ago

Update RuboCop to 0.78 (#32530).

Revision 19411
Added by Go MAEDA over 2 years ago

Update RuboCop to 0.79 (#32530).

Revision 19522
Added by Go MAEDA over 2 years ago

Update RuboCop to 0.80 (#32530).

Revision 19645
Added by Go MAEDA over 2 years ago

Update RuboCop to 0.81 (#32530).

Revision 20152
Added by Go MAEDA almost 2 years ago

Fix a RuboCop offence Style/MethodDefParentheses (#32530).

Revision 20153
Added by Go MAEDA almost 2 years ago

Fix RuboCop offense Style/For (#32530).

Revision 20170
Added by Go MAEDA almost 2 years ago

Update .rubocop_todo.yml (#32530).

Revision 20171
Added by Go MAEDA almost 2 years ago

Update RuboCop to 1.0 (#32530).

Revision 20189
Added by Toshi MARUYAMA almost 2 years ago

restore r18851 lost by r20171 (#32530)

Revision 20190
Added by Toshi MARUYAMA almost 2 years ago

restore r18857 lost by r20171 (#32530)

Revision 20578
Added by Go MAEDA over 1 year ago

Update .rubocop_todo.yml (#32530).

Revision 20579
Added by Go MAEDA over 1 year ago

Update RuboCop to 1.5.2 (#32530).

Note: RubooCop 1.5.0 and 1.5.1 cannot be used for Redmine. This is because those versions of RuboCop requires regexp_parser >= 2.0 while Capybara requires regexp_parser ~> 1.5.

Revision 20714
Added by Go MAEDA over 1 year ago

Update .rubocop_todo.yml (#32530).

Revision 20715
Added by Go MAEDA over 1 year ago

Update RuboCop to 1.8.1 (#32530).

Revision 20739
Added by Go MAEDA over 1 year ago

Update RuboCop to 1.9.1 (#32530).

Revision 20750
Added by Go MAEDA over 1 year ago

Update .rubocop_todo.yml (#32530).

Revision 20751
Added by Go MAEDA over 1 year ago

Update RuboCop to 1.10.0 (#32530).

Revision 20758
Added by Go MAEDA over 1 year ago

Update RuboCop to 1.11.0 (#32530).

Revision 20838
Added by Go MAEDA over 1 year ago

Update .rubocop_todo.yml (#32530).

Revision 20839
Added by Go MAEDA over 1 year ago

Update RuboCop to 1.12.0 (#32530).

History

#1 Updated by Go MAEDA over 2 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch.

#2 Updated by Go MAEDA over 2 years ago

  • Subject changed from Update RuboCop to 0.77 to Update RuboCop to 0.78

Updated to 0.78 in r19405.

#3 Updated by Go MAEDA over 2 years ago

  • Subject changed from Update RuboCop to 0.78 to Update RuboCop to 0.79

Updated to 0.79 in r19411.

#4 Updated by Go MAEDA over 2 years ago

  • Subject changed from Update RuboCop to 0.79 to Update RuboCop to 0.80

Updated to RuboCop 0.80 in r19522.

#5 Updated by Go MAEDA over 2 years ago

  • Subject changed from Update RuboCop to 0.80 to Update RuboCop to 0.81

Updated to RuboCop 0.81 in r19645.

#6 Updated by Marius BALTEANU over 2 years ago

After r19643, we can remove some to dos from rubocop_todo.yml. Patch attached.

#7 Updated by Go MAEDA over 2 years ago

Marius BALTEANU wrote:

After r19643, we can remove some to dos from rubocop_todo.yml. Patch attached.

I think they were removed in r19644.

#8 Updated by Go MAEDA over 2 years ago

  • Status changed from Reopened to Closed

#9 Updated by Go MAEDA almost 2 years ago

  • Subject changed from Update RuboCop to 0.81 to Update RuboCop to 0.93
  • Status changed from Closed to Reopened

Since Ruby 2.3 support is going to be dropped by #34142, we will be able to update to RuboCop to the latest version that supports Ruby 2.4 or later.

#10 Updated by Go MAEDA almost 2 years ago

Here is a patch updates RuboCop to 0.93.

#11 Updated by Go MAEDA almost 2 years ago

#12 Updated by Go MAEDA almost 2 years ago

  • Blocked by Patch #34150: Use match? instead of =~ when MatchData is not used added

#13 Updated by Go MAEDA almost 2 years ago

  • Subject changed from Update RuboCop to 0.93 to Update RuboCop to 1.0

#14 Updated by Go MAEDA almost 2 years ago

  • Status changed from Reopened to Closed

Updated RuboCop to 1.0 in r20171.

#15 Updated by Go MAEDA over 1 year ago

  • Subject changed from Update RuboCop to 1.0 to Update RuboCop to 1.5

Updated RuboCop to 1.5 in r20579.

#16 Updated by Go MAEDA over 1 year ago

  • Subject changed from Update RuboCop to 1.5 to Update RuboCop to 1.8

Updated RuboCop to 1.8 in r20715.

#17 Updated by Go MAEDA over 1 year ago

  • Subject changed from Update RuboCop to 1.8 to Update RuboCop to 1.10

Updated RuboCop to 1.10 in r20751.

#18 Updated by Go MAEDA over 1 year ago

  • Subject changed from Update RuboCop to 1.10 to Update RuboCop to 1.11

Updated RuboCop to 1.11 in r20758.

#19 Updated by Go MAEDA over 1 year ago

  • Subject changed from Update RuboCop to 1.11 to Update RuboCop to 1.12

Updated RuboCop to 1.12 in r20839.

Also available in: Atom PDF