Actions
Defect #32793
closed
Email address with Punycode top-level domain is not accepted
Status:
Closed
Priority:
Normal
Assignee:
Category:
Accounts / authentication
Target version:
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
Redmine does not accept email addresses that have Punycode top-level domain such as "jsmith@example.xn--80akhbyknj4f" (example.ИСПЫТАНИЕ). There are already over 150 TLDs that begin with "xn--" in the real world (see https://www.icann.org/resources/pages/tlds-2012-02-25-en), so Redmine should accept those domains.
The attached relaxes the validation rule for an email address to accept top-level domains which begin with "xn--".
Related issues
Updated by Go MAEDA over 4 years ago
The issue can be fixed if the regular expression is changed as follows:
diff --git a/app/models/email_address.rb b/app/models/email_address.rb
index 46bca384a..dd0b30607 100644
--- a/app/models/email_address.rb
+++ b/app/models/email_address.rb
@@ -20,7 +20,7 @@
class EmailAddress < ActiveRecord::Base
include Redmine::SafeAttributes
- EMAIL_REGEXP = /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\z/i
+ EMAIL_REGEXP = /\A([^@\s]+)@((?:[-a-z0-9]+\.)+(?:(?:xn--[-a-z0-9]+)|(?:[a-z]{2,})))\z/i
belongs_to :user
Updated by Go MAEDA over 4 years ago
- Related to Feature #29208: Support email addresses with IDN (internationalized domain names) in user accounts added
Updated by Go MAEDA over 4 years ago
- Target version set to 4.1.1
Setting the target version to 4.1.1.
Updated by Jean-Philippe Lang about 4 years ago
- Status changed from New to Resolved
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Committed and test added, thanks.
Updated by Go MAEDA over 2 years ago
- Related to Defect #6088: eMail in uncommon formats considered invalid added
Actions