Defect #32832

FrozenError when exporting content to PDF in some languages

Added by Pavel Rosický about 1 month ago. Updated about 1 month ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:PDF export
Target version:4.1.1
Resolution:Fixed Affected version:

fix_pdfexport.patch Magnifier (1.46 KB) Pavel Rosický, 2020-01-17 20:11

fix_pdfexport2.patch Magnifier (1.3 KB) Pavel Rosický, 2020-01-18 08:45

Associated revisions

Revision 19435
Added by Go MAEDA about 1 month ago

FrozenError when exporting gantt to PDF in some languages (#32832).

Patch by Pavel Rosický.

Revision 19436
Added by Go MAEDA about 1 month ago

Merged r19435 from trunk to 4.1-stable (#32832).

History

#1 Updated by Go MAEDA about 1 month ago

  • Tracker changed from Patch to Defect
  • Status changed from New to Confirmed
  • Target version set to 4.1.1

I think the change in SetFontStyle can be ommitted and fixing only SetFont is enough. What do you think?

diff --git a/lib/redmine/export/pdf.rb b/lib/redmine/export/pdf.rb
index c8189367b..85beb8bdb 100644
--- a/lib/redmine/export/pdf.rb
+++ b/lib/redmine/export/pdf.rb
@@ -52,6 +52,7 @@ module Redmine
         end

         def SetFont(family, style='', size=0, fontfile='')
+          style = +style
           # FreeSerif Bold Thai font has problem.
           style.delete!('B') if family.to_s.casecmp('freeserif') == 0
           # DejaVuSans Italic Arabic and Persian font has problem.

#2 Updated by Pavel Rosický about 1 month ago

you're right

#4 Updated by Go MAEDA about 1 month ago

  • Subject changed from pdf export - frozen error to FrozenError when exporting gantt to PDF in some languages
  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you.

#5 Updated by Go MAEDA about 1 month ago

  • Subject changed from FrozenError when exporting gantt to PDF in some languages to FrozenError when exporting content to PDF in some languages

Also available in: Atom PDF