Defect #32896

Totals not working in projects list view

Added by Go MAEDA about 1 year ago. Updated about 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Projects
Target version:4.1.1
Resolution:Fixed Affected version:

Description

Projects list view that was introduced in Redmine 4.1.0 has "Totals" checkboxes if numeric custom fields are defined for projects. The total value of the custom fields is expected to be displayed when the checkbox is on, I think.

However, the total value is not displayed even if the checkbox is on. It seems that the checkbox is not working at all.

total-value-missing@2x.png (56.1 KB) Go MAEDA, 2020-01-27 16:26

0001-Fix-totals-not-displayed-in-projects-list-view.patch Magnifier (2.37 KB) Marius BALTEANU, 2020-01-27 23:08

fix_stylelint_violation.patch Magnifier (626 Bytes) Marius BALTEANU, 2020-02-09 16:10

Associated revisions

Revision 19469
Added by Go MAEDA about 1 year ago

Fix totals not displayed in projects list view (#32896).

Patch by Marius BALTEANU.

Revision 19470
Added by Go MAEDA about 1 year ago

Merged r19469 from trunk to 4.1-stable (#32896).

Revision 19503
Added by Go MAEDA about 1 year ago

Fix a Stylelint violation (#32896).

Patch by Marius BALTEANU.

Revision 19504
Added by Go MAEDA about 1 year ago

Merged r19503 from trunk to 4.1-stable (#32896).

History

#1 Updated by Marius BALTEANU about 1 year ago

  • Status changed from New to Confirmed
  • Assignee set to Marius BALTEANU
  • Target version set to 4.1.1

#2 Updated by Marius BALTEANU about 1 year ago

Here is the fix with a test. Thanks for detecting the issue. All tests pass.

#3 Updated by Go MAEDA about 1 year ago

  • Resolution set to Fixed

Committed the patch. Thank you for posting the patch so quickly.

#4 Updated by Go MAEDA about 1 year ago

  • Status changed from Confirmed to Closed

#5 Updated by Marius BALTEANU about 1 year ago

My patch introduced a new Stylelint violation, please commit the attached fix.

 public/stylesheets/application.css
  410:1  ✖  Unexpected duplicate selector ".query-totals", first used at line 407   no-duplicate-selectors

#6 Updated by Go MAEDA about 1 year ago

  • Status changed from Reopened to Closed

Marius BALTEANU wrote:

My patch introduced a new Stylelint violation, please commit the attached fix.

[...]

Committed the patch.

Also available in: Atom PDF