Patch #32927

CSS selector in test_index_should_show_warning_when_no_workflow_is_defined is too specific

Added by Vincent Robert 9 months ago. Updated 9 months ago.

Status:ClosedStart date:
Priority:LowDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:4.2.0

Description

Hi
Just a tiny patch which makes a test less specific. This way, a plugin can add columns to the table without breaking core tests.
Thank you

more_generic_test.diff Magnifier (711 Bytes) Vincent Robert, 2020-01-30 14:24

Associated revisions

Revision 19521
Added by Go MAEDA 9 months ago

Fix that CSS selector in test_index_should_show_warning_when_no_workflow_is_defined is too specific (#32927).

Patch by Vincent Robert.

History

#1 Updated by Go MAEDA 9 months ago

Plugins often break core tests. Should we relax tests every time a plugin the test suite?

#2 Updated by Vincent Robert 9 months ago

No, we should not ;) But I think this specific test is too precise. It will break as soon as the table is modified, even if the tested function has not changed.

But feel free to close my issue if you prefer to not update the current tests.

#3 Updated by Go MAEDA 9 months ago

I am not in favor of accepting this patch as it is for the following reasons:

  • If the patch is accepted, many plugin developers may request to loosen tests only to fix test failures caused by their plugins
  • There are some other ":nth-of-type" in the test suite. Changing only one place makes the test inconsistent

However, I think it is OK to change "td:nth-of-type(3)" to "td.CLASS_NAME" instead of loosening the tests.

#4 Updated by Go MAEDA 9 months ago

Go MAEDA wrote:

I am not in favor of accepting this patch as it is for the following reasons:

  • If the patch is accepted, many plugin developers may request to loosen tests only to fix test failures caused by their plugins
  • There are some other ":nth-of-type" in the test suite. Changing only one place makes the test inconsistent

However, I think it is OK to change "td:nth-of-type(3)" to "td.CLASS_NAME" instead of loosening the tests.

I have changed my mind.

I just noticed that the message to test can be specified by span.icon-warning. Now I think the current code is too strict and there is no problem to merge the suggested patch.

#5 Updated by Go MAEDA 9 months ago

  • Target version changed from 4.0.7 to 4.2.0

#6 Updated by Go MAEDA 9 months ago

  • Subject changed from Tiny patch which make a test less specific - Make easier for plugins to not break it to CSS selector in test_index_should_show_warning_when_no_workflow_is_defined is too specific
  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you.

Also available in: Atom PDF