Project

General

Profile

Actions
Copy link

Defect #3302

closed

No tab highlighting for Simple-CI plugin

Added by Mischa The Evil about 15 years ago. Updated about 15 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Eric Davis
Category:
Plugin API
Target version:
-
Start date:
2009-05-06
Due date:
% Done:

0%

Estimated time:
Resolution:
Affected version:

Description

The project-menu item (tab) doesn't highlight correctly in version 1.0 of the Simple-CI plugin.

I'd like to propose the following fix for it. Change source:/plugins/simple_ci/init.rb#L44 from:

 menu :project_menu, 'Integration', :controller => 'simple_ci', :action => 'show'
to:
 menu :project_menu, :simple_ci, { :controller => 'simple_ci', :action => 'show' }, :caption => 'Integration'

This fix will affect the CSS class-names thus it can break third-party code relying on the currently used class-name Integration. My proposed fix will change this class-name to simple-ci.

Actions
Copy link
 #1

Updated by Jean-Philippe Lang about 15 years ago

  • Status changed from New to Closed

Fixed in r2721.

Actions
Copy link

Also available in: Atom PDF