Patch #33100

Fix a test - Issue watchers are not always sorted by id

Added by Vincent Robert over 1 year ago. Updated over 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:-
Target version:-

Description

Hello
Could you please apply this tiny patch?

Currently, when running issues_controller tests, returned issue-watchers are not always sorted by id, which may break the tests.

line 5245 in class IssuesControllerTest
-    assert_equal [3, 10], issue.watcher_user_ids
+    assert_equal [3, 10], issue.watcher_user_ids.sort

Thank you for your work
Vincent

test_fix.diff Magnifier (555 Bytes) Vincent Robert, 2020-03-05 12:14


Related issues

Related to Redmine - Feature #4511: Allow adding user groups as watchers for issues Closed 2010-01-01

Associated revisions

Revision 19562
Added by Go MAEDA over 1 year ago

Fix that IssuesControllerTest occasionally fails (#33100, #4511).

Patch by Vincent Robert.

History

#1 Updated by Go MAEDA over 1 year ago

  • Related to Feature #4511: Allow adding user groups as watchers for issues added

#2 Updated by Go MAEDA over 1 year ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the fix as a part of #4511. Thank you for detecting and fixing the issue.

Also available in: Atom PDF