Defect #33175

Starting or ending marker is not displayed if they are on the leftmost or rightmost boundary of the gantt

Added by Yuichi HARADA 7 months ago. Updated 2 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Gantt
Target version:4.0.8
Resolution:Fixed Affected version:

Description

If the start date is the first day of the Gantt or the due date is the last day of the Gantt, the mark of the Gantt bar is not displayed.

expect actual

expect.png (266 KB) Yuichi HARADA, 2020-03-19 04:09

actual.png (224 KB) Yuichi HARADA, 2020-03-19 04:09

33175.patch Magnifier (2.59 KB) Yuichi HARADA, 2020-03-19 04:16

33175-r19958.patch Magnifier (2.28 KB) Go MAEDA, 2020-08-09 09:17


Related issues

Related to Redmine - Defect #33140: Gantt bar is not displayed if the due date is the leftmos... Closed

Associated revisions

Revision 19976
Added by Go MAEDA 2 months ago

Starting or ending marker is not displayed if they are on the leftmost or rightmost boundary of the gantt (#33175).

Patch by Yuichi HARADA.

Revision 19980
Added by Go MAEDA 2 months ago

Merged r19976 from trunk to 4.1-stable (#33175).

Revision 19981
Added by Go MAEDA 2 months ago

Merged r19976 from trunk to 4.0-stable (#33175).

History

#1 Updated by Yuichi HARADA 7 months ago

Resolve with the following patch.

diff --git a/lib/redmine/helpers/gantt.rb b/lib/redmine/helpers/gantt.rb
index 285eb66a0..ad9bab8ad 100644
--- a/lib/redmine/helpers/gantt.rb
+++ b/lib/redmine/helpers/gantt.rb
@@ -624,13 +624,13 @@ module Redmine
         zoom ||= @zoom
         coords = {}
         if start_date && end_date && start_date < self.date_to && end_date > self.date_from
-          if start_date > self.date_from
+          if start_date >= self.date_from
             coords[:start] = start_date - self.date_from
             coords[:bar_start] = start_date - self.date_from
           else
             coords[:bar_start] = 0
           end
-          if end_date < self.date_to
+          if end_date <= self.date_to
             coords[:end] = end_date - self.date_from
             coords[:bar_end] = end_date - self.date_from + 1
           else

#2 Updated by Go MAEDA 7 months ago

  • Target version set to Candidate for next minor release

#3 Updated by Go MAEDA 3 months ago

Updated the patch for the latest trunk.

#4 Updated by Go MAEDA 3 months ago

  • Related to Defect #33140: Gantt bar is not displayed if the due date is the leftmost date or the start date is the rightmost date added

#5 Updated by Go MAEDA 3 months ago

  • Status changed from New to Confirmed
  • Target version changed from Candidate for next minor release to 4.0.8

Setting the target version to 4.0.8.

#6 Updated by Go MAEDA 2 months ago

  • Subject changed from Gantt bar's mark is not displayed if the start date is the first day of the Gantt to Starting or ending marker is not displayed if they are on the leftmost or rightmost boundary of the gantt
  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for your contribution.

#7 Updated by Go MAEDA 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF