Feature #33383
Update jQuery to 3.5.1
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | Third-party libraries | |||
| Target version: | 4.2.0 | |||
| Resolution: | Fixed |
Description
jQuery 2 is end of life and we should update the code to support latest jQuery 3.5.0 (at this time).
0002-Fix-cannot-set-property-dragover-of-undefined-jQuery.patch 
(1016 Bytes)
0001-Update-jQuery-to-3.5.1-without-jQuery-Migrate.patch
(183 KB)
add-jquery-migrate.patch
(11.7 KB)
remove_security_fix_for_jquery_1_2.patch
(585 Bytes)
Related issues
Associated revisions
Update jQuery to 3.5.1 without jQuery Migrate (#33383).
Patch by Marius BALTEANU.
Fix cannot set property 'dragover' of undefined (#33383).
Patch by Marius BALTEANU.
Add jQuery Migrate (#33383).
Remove security fix for JQuery 1.2 (#33383).
Patch by Marius BALTEANU.
History
#1
Updated by Marius BALTEANU over 2 years ago
- Related to Patch #33384: jQuery: replace deprecated size() method with length added
#2
Updated by Marius BALTEANU over 2 years ago
- Related to Defect #33392: Fix invalid selector in function displayTabsButtons() added
#3
Updated by Marius BALTEANU about 2 years ago
- File 0002-Fix-cannot-set-property-dragover-of-undefined-jQuery.patch added
- File 0001-Update-jQuery-to-3.5.1-without-jQuery-Migrate.patch added
- Subject changed from Update jQuery to 3.5.0 to Update jQuery to 3.5.1
- Assignee deleted (
Marius BALTEANU)
Here are two patches that update jQuery to 3.5.1 and fix a problem caused by this change.
Because the update can break some plugins, I propose the following plan for this update:- Commit the current patches
- Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
- After this period, commit jQuery Migrate
- In Redmine 5.0.0, remove jQuery Migrate and keep only the latest jQuery version.
#4
Updated by Go MAEDA about 2 years ago
Thank you for working on updating JQuery.
Marius BALTEANU wrote:
Because the update can break some plugins, I propose the following plan for this update:
- Commit the current patches
- Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
- After this period, commit jQuery Migrate
I agree. In order to make enough time to discover and fix issues caused by the update, I think it is better to commit the patches as soon as we can.
Do you think it is OK to commit the patches right now?
#5
Updated by Go MAEDA about 2 years ago
- Target version changed from Candidate for next major release to 4.2.0
I think it is better to commit this patch as soon as possible in order to detect problems early. Setting the target version to 4.2.0.
#6
Updated by Go MAEDA about 2 years ago
- Status changed from New to Resolved
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patches. Thank you.
#7
Updated by Marius BALTEANU about 2 years ago
Go MAEDA wrote:
Thank you for working on updating JQuery.
Marius BALTEANU wrote:
Because the update can break some plugins, I propose the following plan for this update:
- Commit the current patches
- Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
- After this period, commit jQuery Migrate
I agree. In order to make enough time to discover and fix issues caused by the update, I think it is better to commit the patches as soon as we can.
Do you think it is OK to commit the patches right now?
Sorry for my late reply, yes, it's ok to have the patches committed.
#8
Updated by Go MAEDA almost 2 years ago
- Related to Defect #33896: Incorrect position of the revision graph added
#9
Updated by Go MAEDA over 1 year ago
- File add-jquery-migrate.patch added
- Assignee changed from Go MAEDA to Marius BALTEANU
Marius BALTEANU wrote:
Because the update can break some plugins, I propose the following plan for this update:
- Commit the current patches
- Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
- After this period, commit jQuery Migrate
- In Redmine 5.0.0, remove jQuery Migrate and keep only the latest jQuery version.
Six months have passed since upgrading JQuery to 3.5.1. I think it is time to add jquery-migrate. Marius, what is your opinion?
#10
Updated by Marius BALTEANU over 1 year ago
Go MAEDA wrote:
Marius BALTEANU wrote:
Because the update can break some plugins, I propose the following plan for this update:
- Commit the current patches
- Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
- After this period, commit jQuery Migrate
- In Redmine 5.0.0, remove jQuery Migrate and keep only the latest jQuery version.
Six months have passed since upgrading JQuery to 3.5.1. I think it is time to add jquery-migrate. Marius, what is your opinion?
Yes, let's do it.
#11
Updated by Go MAEDA over 1 year ago
- Related to Feature #34337: Remove jQuery Migrate added
#12
Updated by Go MAEDA over 1 year ago
- Status changed from Resolved to Closed
- Assignee changed from Marius BALTEANU to Go MAEDA
Added jQuery Migrate in r20518.
#13
Updated by Marius BALTEANU over 1 year ago
- File remove_security_fix_for_jquery_1_2.patch added
- Status changed from Closed to Reopened
We should remove the security fix for jQuery < 3.
#14
Updated by Go MAEDA over 1 year ago
- Status changed from Reopened to Closed
#15
Updated by Go MAEDA over 1 year ago
- Category changed from Code cleanup/refactoring to Third-party libraries
#16
Updated by Marius BALTEANU about 1 year ago
- Related to Patch #35729: Update jQuery to 3.6.0 added