Feature #33383
Update jQuery to 3.5.1
| Status: | Resolved | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | Code cleanup/refactoring | |||
| Target version: | 4.2.0 | |||
| Resolution: | Fixed |
Description
jQuery 2 is end of life and we should update the code to support latest jQuery 3.5.0 (at this time).
0002-Fix-cannot-set-property-dragover-of-undefined-jQuery.patch 
(1016 Bytes)
0001-Update-jQuery-to-3.5.1-without-jQuery-Migrate.patch
(183 KB)
Related issues
Associated revisions
Update jQuery to 3.5.1 without jQuery Migrate (#33383).
Patch by Marius BALTEANU.
Fix cannot set property 'dragover' of undefined (#33383).
Patch by Marius BALTEANU.
History
#1
Updated by Marius BALTEANU about 1 month ago
- Related to Patch #33384: jQuery: replace deprecated size() method with length added
#2
Updated by Marius BALTEANU about 1 month ago
- Related to Defect #33392: Fix invalid selector in function displayTabsButtons() added
#3
Updated by Marius BALTEANU 17 days ago
- File 0002-Fix-cannot-set-property-dragover-of-undefined-jQuery.patch added
- File 0001-Update-jQuery-to-3.5.1-without-jQuery-Migrate.patch added
- Subject changed from Update jQuery to 3.5.0 to Update jQuery to 3.5.1
- Assignee deleted (
Marius BALTEANU)
Here are two patches that update jQuery to 3.5.1 and fix a problem caused by this change.
Because the update can break some plugins, I propose the following plan for this update:- Commit the current patches
- Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
- After this period, commit jQuery Migrate
- In Redmine 5.0.0, remove jQuery Migrate and keep only the latest jQuery version.
#4
Updated by Go MAEDA 14 days ago
Thank you for working on updating JQuery.
Marius BALTEANU wrote:
Because the update can break some plugins, I propose the following plan for this update:
- Commit the current patches
- Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
- After this period, commit jQuery Migrate
I agree. In order to make enough time to discover and fix issues caused by the update, I think it is better to commit the patches as soon as we can.
Do you think it is OK to commit the patches right now?