Feature #33383

Update jQuery to 3.5.1

Added by Marius BALTEANU 9 months ago. Updated 6 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Third-party libraries
Target version:4.2.0
Resolution:Fixed

Description

jQuery 2 is end of life and we should update the code to support latest jQuery 3.5.0 (at this time).

0002-Fix-cannot-set-property-dragover-of-undefined-jQuery.patch Magnifier (1016 Bytes) Marius BALTEANU, 2020-05-20 23:04

0001-Update-jQuery-to-3.5.1-without-jQuery-Migrate.patch Magnifier (183 KB) Marius BALTEANU, 2020-05-20 23:04

add-jquery-migrate.patch Magnifier (11.7 KB) Go MAEDA, 2020-11-29 06:52

remove_security_fix_for_jquery_1_2.patch Magnifier (585 Bytes) Marius BALTEANU, 2021-01-09 12:59

Related issues

Related to Redmine - Patch #33384: jQuery: replace deprecated size() method with length Closed
Related to Redmine - Defect #33392: Fix invalid selector in function displayTabsButtons() Closed
Related to Redmine - Defect #33896: Incorrect position of the revision graph Closed
Related to Redmine - Feature #34337: Remove jQuery Migrate New

Associated revisions

Revision 19803
Added by Go MAEDA 8 months ago

Update jQuery to 3.5.1 without jQuery Migrate (#33383).

Patch by Marius BALTEANU.

Revision 19804
Added by Go MAEDA 8 months ago

Fix cannot set property 'dragover' of undefined (#33383).

Patch by Marius BALTEANU.

Revision 20147
Added by Go MAEDA 3 months ago

Incorrect position of the revision graph (#33896, #33383).

Patch by Marius BALTEANU.

Revision 20336
Added by Go MAEDA 2 months ago

Fix that "View differences" buttons on RepositoriesController#diff page does not work due to r20147 (#33896, #33383).

Patch by Mizuki ISHIKAWA.

Revision 20518
Added by Go MAEDA about 1 month ago

Add jQuery Migrate (#33383).

Revision 20709
Added by Go MAEDA 6 days ago

Remove security fix for JQuery 1.2 (#33383).

Patch by Marius BALTEANU.

History

#1 Updated by Marius BALTEANU 9 months ago

  • Related to Patch #33384: jQuery: replace deprecated size() method with length added

#2 Updated by Marius BALTEANU 9 months ago

  • Related to Defect #33392: Fix invalid selector in function displayTabsButtons() added

#3 Updated by Marius BALTEANU 8 months ago

Here are two patches that update jQuery to 3.5.1 and fix a problem caused by this change.

Because the update can break some plugins, I propose the following plan for this update:
  1. Commit the current patches
  2. Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
  3. After this period, commit jQuery Migrate
  4. In Redmine 5.0.0, remove jQuery Migrate and keep only the latest jQuery version.

#4 Updated by Go MAEDA 8 months ago

Thank you for working on updating JQuery.

Marius BALTEANU wrote:

Because the update can break some plugins, I propose the following plan for this update:
  1. Commit the current patches
  2. Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
  3. After this period, commit jQuery Migrate

I agree. In order to make enough time to discover and fix issues caused by the update, I think it is better to commit the patches as soon as we can.

Do you think it is OK to commit the patches right now?

#5 Updated by Go MAEDA 8 months ago

  • Target version changed from Candidate for next major release to 4.2.0

I think it is better to commit this patch as soon as possible in order to detect problems early. Setting the target version to 4.2.0.

#6 Updated by Go MAEDA 8 months ago

  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patches. Thank you.

#7 Updated by Marius BALTEANU 7 months ago

Go MAEDA wrote:

Thank you for working on updating JQuery.

Marius BALTEANU wrote:

Because the update can break some plugins, I propose the following plan for this update:
  1. Commit the current patches
  2. Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
  3. After this period, commit jQuery Migrate

I agree. In order to make enough time to discover and fix issues caused by the update, I think it is better to commit the patches as soon as we can.

Do you think it is OK to commit the patches right now?

Sorry for my late reply, yes, it's ok to have the patches committed.

#8 Updated by Go MAEDA 5 months ago

  • Related to Defect #33896: Incorrect position of the revision graph added

#9 Updated by Go MAEDA about 1 month ago

Marius BALTEANU wrote:

Because the update can break some plugins, I propose the following plan for this update:
  1. Commit the current patches
  2. Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
  3. After this period, commit jQuery Migrate
  4. In Redmine 5.0.0, remove jQuery Migrate and keep only the latest jQuery version.

Six months have passed since upgrading JQuery to 3.5.1. I think it is time to add jquery-migrate. Marius, what is your opinion?

#10 Updated by Marius BALTEANU about 1 month ago

Go MAEDA wrote:

Marius BALTEANU wrote:

Because the update can break some plugins, I propose the following plan for this update:
  1. Commit the current patches
  2. Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
  3. After this period, commit jQuery Migrate
  4. In Redmine 5.0.0, remove jQuery Migrate and keep only the latest jQuery version.

Six months have passed since upgrading JQuery to 3.5.1. I think it is time to add jquery-migrate. Marius, what is your opinion?

Yes, let's do it.

#11 Updated by Go MAEDA about 1 month ago

#12 Updated by Go MAEDA about 1 month ago

  • Status changed from Resolved to Closed
  • Assignee changed from Marius BALTEANU to Go MAEDA

Added jQuery Migrate in r20518.

#13 Updated by Marius BALTEANU 7 days ago

We should remove the security fix for jQuery < 3.

#14 Updated by Go MAEDA 6 days ago

  • Status changed from Reopened to Closed

Marius BALTEANU wrote:

We should remove the security fix for jQuery < 3.

Done in r20709.

#15 Updated by Go MAEDA 6 days ago

  • Category changed from Code cleanup/refactoring to Third-party libraries

Also available in: Atom PDF