Defect #33452

Untranslated string "diff" in journal detail

Added by Go MAEDA 22 days ago. Updated 22 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:I18n
Target version:4.1.2
Resolution:Fixed Affected version:

Description

The fix was submitted by Kam Nazir as part of Defect #31698. I have extracted this single fix from #31698 that contains multiple fixes because the hard-coded "diff" can be fixed without adding a new string to config/locales/*.yml files.

diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index 6b63f7e11..e18ff147a 100644
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -553,7 +553,7 @@ module IssuesHelper
       unless no_html
         diff_link =
           link_to(
-            'diff',
+            l(:label_diff),
             diff_journal_url(detail.journal_id, :detail_id => detail.id,
                              :only_path => options[:only_path]),
             :title => l(:label_view_diff))

diff-is-not-translated.png (24.1 KB) Go MAEDA, 2020-05-16 01:54


Related issues

Related to Redmine - Defect #31698: Some unlocalize string New

Associated revisions

Revision 19780
Added by Go MAEDA 22 days ago

Untranslated string "diff" in journal detail (#33452).

Patch by Kam Nazir.

Revision 19781
Added by Go MAEDA 22 days ago

Merged r19780 from trunk to 4.1-stable (#33452).

History

#1 Updated by Go MAEDA 22 days ago

#2 Updated by Go MAEDA 22 days ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix contributed by Kam Nazir. Thank you.

Also available in: Atom PDF