Defect #33829

Tags "updated" in issues atom are "created on"

Added by Tatsuya Saito 12 months ago. Updated 5 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Feeds
Target version:Candidate for next major release
Resolution: Affected version:4.1.1

Description

There are updated tags in the Atom of issues list.
However, the created on is exported.

I have attached a patch to fix this.

patch.diff Magnifier (759 Bytes) Tatsuya Saito, 2020-08-08 09:34

patch_trunk_r19958_pt1.diff Magnifier - note-3 patch pattern 1 (2.64 KB) Tatsuya Saito, 2020-08-08 17:26

patch_trunk_r19958_pt2.diff Magnifier - note-3 patch pattern 2 (924 Bytes) Tatsuya Saito, 2020-08-08 17:26

History

#1 Updated by Tatsuya Saito 12 months ago

This issue is reported in following Japanese forum.
https://groups.google.com/forum/#!topic/redmine-users-ja/wb78I8uVJEY

#2 Updated by Tatsuya Saito 12 months ago

I'm sorry, patch.diff breaks Redmine rake test.
It breaks activity view items.
Please reject the patch.

#3 Updated by Tatsuya Saito 12 months ago

I think this problem only affects the atom of issues list.
There are updated tags created by issue.event_datetime.
But issue.event_datetime is created_on.
I think you need to use updated_on for the atom of issue list.

I re-create the patches for this issue.
In the first pattern, issue_controller overwrites issue.event_datetime between atom exports.
The second pattern, application_controller.rb and common/feed.atom.builder, adds the code for the problem list atom.

Both work, but I don't think it's clean code.
I'll attach both patches in the hope that it will help you think about better code.

#4 Updated by Go MAEDA 11 months ago

  • Category changed from Issues list to Feeds

#5 Updated by Go MAEDA 5 months ago

  • Target version set to Candidate for next major release

Also available in: Atom PDF