Patch #34444

Remove unused key :preview from Redmine::AccessKeys::ACCESSKEYS

Added by Go MAEDA about 1 month ago. Updated 18 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:4.2.0

Description

As reported in #30459, Redmine 4.0 and later no longer supports the accesskey "r" (updates the preview in editor mode) due to the improvement of UI made by #27758.

The definition of the accesskey should be removed.

diff --git a/lib/redmine/access_keys.rb b/lib/redmine/access_keys.rb
index db66c7d84..a64ac0673 100644
--- a/lib/redmine/access_keys.rb
+++ b/lib/redmine/access_keys.rb
@@ -22,7 +22,6 @@ module Redmine
     unless const_defined?(:ACCESSKEYS)
       ACCESSKEYS = {
         :edit => 'e',
-        :preview => 'r',
         :quick_search => 'f',
         :search => '4',
         :new_issue => '7',

Related issues

Related to Redmine - Feature #27758: Adds preview option to the wiki toolbar Closed
Related to Redmine - Feature #30459: Switch edit/preview tabs with keybord shortcuts Closed

Associated revisions

Revision 20705
Added by Go MAEDA 18 days ago

Remove unused key :preview from Redmine::AccessKeys::ACCESSKEYS (#34444).

Patch by Go MAEDA.

History

#1 Updated by Go MAEDA about 1 month ago

  • Related to Feature #27758: Adds preview option to the wiki toolbar added

#2 Updated by Go MAEDA about 1 month ago

  • Related to Feature #30459: Switch edit/preview tabs with keybord shortcuts added

#3 Updated by Go MAEDA 22 days ago

  • Target version set to 4.2.0

Setting the target version to 4.2.0.

#4 Updated by Go MAEDA 18 days ago

  • Subject changed from Remove :preview from Redmine::AccessKeys::ACCESSKEYS to Remove unused key :preview from Redmine::AccessKeys::ACCESSKEYS
  • Assignee set to Go MAEDA

Committed the patch.

#5 Updated by Go MAEDA 18 days ago

  • Status changed from New to Closed

Also available in: Atom PDF