Defect #3480

Bot filter plugin crashes when missing useragent

Added by Brad Schick over 10 years ago. Updated over 6 years ago.

Status:ClosedStart date:2009-06-11
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-
Resolution: Affected version:

Description

Using the BotsFilterPlugin, I noticed exceptions when there was no useragent in a request. I applied the following patch to fix this. Note that this patch blocks requests with missing useragents as if they were bots.

bot_filter.patch Magnifier - Test for nil useragent (460 Bytes) Brad Schick, 2009-06-11 08:50

allow_empty_user_agent.patch Magnifier (477 Bytes) Jérémy Lal, 2010-06-18 00:36

History

#1 Updated by Jérémy Lal over 9 years ago

  • Assignee changed from Eric Davis to Jean-Philippe Lang

I confirm that bug,
which BTW breaks rake tests.

Assigning to JP Lang since he's the one releasing botsfilter plugin.

Regards.

#2 Updated by Jérémy Lal over 9 years ago

it's best to not filter requests if user_agent is blank.
See attached patch.

#3 Updated by Jean-Baptiste Barth over 6 years ago

  • Category deleted (Plugin API)
  • Status changed from New to Closed
  • Assignee deleted (Jean-Philippe Lang)

Closing this issue: very old + it is about a specific plugin, the current policy is to report issues in the dedicated bug tracker of each plugin.

Also available in: Atom PDF