Defect #35017

X-Redmine-Issue-Assignee email header field is empty when the assignee of an issue is a group

Added by Akihiro MATOBA 4 months ago. Updated 2 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Email notifications
Target version:5.0.0
Resolution:Fixed Affected version:

Description

When I assign an issue to a group, the X-Redmine-Issue-Assignee: header in the notification mail is empty.

As is:

X-Redmine-Issue-Assignee:

Should be:
X-Redmine-Issue-Assignee: Group (A Team)

35017_v1.patch Magnifier (2.97 KB) Akihiro MATOBA, 2021-04-03 12:54

35017_v2.patch Magnifier (3.06 KB) Go MAEDA, 2021-05-16 08:53


Related issues

Related to Redmine - Feature #19939: New X-Redmine-Issue-Priority header, and modification of ... New

Associated revisions

Revision 21005
Added by Go MAEDA 2 months ago

X-Redmine-Issue-Assignee email header field is empty when the assignee of an issue is a group (#35017).

Patch by Akihiro MATOBA.

History

#1 Updated by Akihiro MATOBA 4 months ago

#2 Updated by Mizuki ISHIKAWA 4 months ago

I reviewed the patch. LGTM.

#3 Updated by Go MAEDA 3 months ago

  • Description updated (diff)

#4 Updated by Go MAEDA 3 months ago

  • Target version set to Candidate for next major release

I think the suggested format (X-Redmine-Issue-Assignee: Group (A Team)) is well considered.

  • If the group name is simply set to X-Redmine-Issue-Assignee, it may conflict with a user’s login, but the proposed format avoids that problem
  • The keyword "Group" never conflicts with a user's login because the first letter is uppercase
  • If in the future we want to extend X-Redmine-Issue-Assignee to include the display name of the user, we can use the same format like "admin (Redmine Admin)"

#5 Updated by Go MAEDA 3 months ago

  • Tracker changed from Patch to Defect
  • Subject changed from "X-Redmine-Issue-Assignee:" header should contain a group name, not empty to X-Redmine-Issue-Assignee header in email notifications is empty when the assignee is a group

#6 Updated by Go MAEDA 3 months ago

  • Target version changed from Candidate for next major release to 5.0.0

Setting the target version to 5.0.0.

#7 Updated by Go MAEDA 2 months ago

Updated the patch. I unified the same code written twice.

#8 Updated by Go MAEDA 2 months ago

  • Related to Feature #19939: New X-Redmine-Issue-Priority header, and modification of X-Redmine-Issue-Assignee added

#9 Updated by Go MAEDA 2 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch.

Now the value of X-Redmine-Issue-Assignee email header field is "Group (#{issue.assigned_to.name})" (example: "Group (A Team)") if the assignee of an issue is a group.

Thank you for your contribution.

#10 Updated by Go MAEDA 2 months ago

  • Subject changed from X-Redmine-Issue-Assignee header in email notifications is empty when the assignee is a group to X-Redmine-Issue-Assignee email header field is empty when the assignee of an issue is a group

Also available in: Atom PDF