Patch #35215
Don't display "No Match Found!" when the inline autocomplete doesn't return any result
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Marius BALTEANU | % Done: | 0% | |
| Category: | UI | |||
| Target version: | 4.2.4 |
Description
Hello there,
it would be very helpful if we would be able to change the "No Match Found!" message that is included via the third party library tribute.js. I could hardcode it into the file itself, but that just seems odd.
Best regards
nomatch.png (6.79 KB)
patch1.diff 
(952 Bytes)
Associated revisions
Don't display "No Match Found!" when the inline autocomplete doesn't return any result (#35215).
Patch by Takashi Kato.
History
#1
Updated by Takashi Kato over 1 year ago
- File patch1.diff added
In the "tribute.js", the "noMatchTemplate" property for each entry in the "collection" is ineffective. (README is confusing. I raise an issue if I can.) The "noMatchTemplate" specified separately from the "collection" is effective.
An empty string is effective if not want to display a message when there is no match. No function is needed. (again, README is confusing.)
#2
Updated by Marius BALTEANU 7 months ago
- Assignee set to Marius BALTEANU
#3
Updated by Marius BALTEANU 7 months ago
- Target version set to Candidate for next minor release
I think it's better to not show any message as Takashi Kato proposes.
#4
Updated by Marius BALTEANU 7 months ago
- Tracker changed from Feature to Patch
- Subject changed from tribute.js third party library localization to Don't display "No Match Found!" when the inline autocomplete doesn't return any result
- Category set to UI
- Status changed from New to Closed
- Target version changed from Candidate for next minor release to 4.2.4
Patch committed, thanks!
I didn't merge it to 4.1-stable because of the conflicts.