Project

General

Profile

Actions

Patch #35312

closed

Gracefully handle invalid operators and associations requested in queries

Added by Holger Just almost 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Filters
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Users can request arbitrary operators or custom field associations for fields in queries for issues or time entries. This is validated in the Query class with an exception being raised if an invalid operator or custom field association was requested.

The attached patch handles this case by raising a named Error instead and gracefully handling this error in the UI by logging the original exception and rendering a 404 error.


Files


Related issues

Related to Redmine - Defect #35062: Back URLs with <t+ operator breakConfirmed

Actions
Related to Redmine - Patch #35500: Add missing fixture to IssuesTestClosedGo MAEDA

Actions
Actions #1

Updated by Holger Just almost 3 years ago

  • Related to Defect #35062: Back URLs with <t+ operator break added
Actions #2

Updated by Holger Just almost 3 years ago

This patch probably masks the underlying issue in #35062 (by rendering a 404 instead of a 500 there). The root cause of this issue should probably still be checked.

Actions #3

Updated by Go MAEDA almost 3 years ago

  • Target version set to 5.0.0

Setting the target version to 5.0.0.

Actions #4

Updated by Go MAEDA almost 3 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you.

Actions #5

Updated by Go MAEDA over 2 years ago

  • Related to Patch #35500: Add missing fixture to IssuesTest added
Actions #6

Updated by Go MAEDA about 2 years ago

  • Category changed from Issues filter to Filters
Actions

Also available in: Atom PDF