Project

General

Profile

Actions

Patch #35466

closed

Rename test/fixtures/configuration/*.yml.example to test/fixtures/files/configuration/*.yml

Added by Go MAEDA almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The test suite has some YAML files that are used by test/unit/lib/redmine/configuration_test.rb. And the YAML files have a file extension ".yml.example" instead of the standard ".yml". This is to prevent "rake db:fixtures:load" from failing (#30811). Files with a “.yml” extension placed under “text/fixtures” directory are treated as test fixtures and cause the failure.

In Rails 6.1.4, db:fixtures:load now ignores YAML files under text/fixtures/files (see https://github.com/rails/rails/pull/42153). This means that "*.yml" files will no longer cause db:fixtures:load to fail if they are placed in that directory and we can stop using an awkward ".yml.example" extension.

The attached patch moves the YAML files under /text/fixtures/files directory and changes the file extension back to ".yml".


Files


Related issues

Related to Redmine - Defect #30811: "rake db:fixtures:load" does not workClosedGo MAEDA

Actions
Related to Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadingClosedGo MAEDA

Actions
Actions

Also available in: Atom PDF