Defect #35545
Fix css class assignment in issue custom field rendering in show view
| Status: | New | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | Issues | |||
| Target version: | - | |||
| Resolution: | Affected version: | 4.2.1 |
Description
Rendering the issue custom fields in the show view is done by the
class IssueFieldsRow, which can be found in issues_helper.rb.
The method IssueFieldRow#to_html has an error because the
class 'splitcontentright' will never be assigned.
This patch fixes this error by modifying the class in the respective
content_tag of the helper method. Thus, it is a one liner.
fix_issue_custom_field_rendering.patch 
- Patches css class assignment
(559 Bytes)
35545-layout-issue.png (164 KB)
35545-layout-issue-flex-css.png (73.4 KB)
fix_issue_custom_field_css.patch
(722 Bytes)
History
#1
Updated by Liane Hampe 12 months ago
This is the content of the patch file:
diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index 756d7ed4c..d43a7db8b 100755
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -332,7 +332,7 @@ module IssuesHelper
def to_html
content =
content_tag('div', @left.reduce(&:+), :class => 'splitcontentleft') +
- content_tag('div', @right.reduce(&:+), :class => 'splitcontentleft')
+ content_tag('div', @right.reduce(&:+), :class => 'splitcontentright')
content_tag('div', content, :class => 'splitcontent')
end
#2
Updated by Go MAEDA 12 months ago
- File 35545-layout-issue.png added
The suggested change causes a layout issue. See the screenshot below.
#3
Updated by Liane Hampe 12 months ago
- File 35545-layout-issue-flex-css.png added
Hi Go MAEDA,
Thank you for this important information.
I have fixed it with some more css:
Old styles:
.splitcontent {overflow: auto; display: flex; flex-wrap: wrap}
.splitcontentleft {flex: 1; margin-right: 5px;}
.splitcontentright {flex: 1; margin-left: 5px;}
New styles:
.splitcontent {overflow: auto; display: flex; flex-wrap: wrap;justify-content: space-between}
.splitcontentleft, .splitcontentright {width: 49.5%}
This is how it looks like now:
It also looks nice on the project overview page where the same css classes are used.
Best Regards
Liane
#4
Updated by Liane Hampe 12 months ago
- File fix_issue_custom_field_css.patch added
Here is the patch file for the css changes.