Feature #35742

Enable task list items for CommonMark text formatting

Added by Marius BALTEANU about 1 year ago. Updated 6 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Marius BALTEANU% Done:

0%

Category:Text formatting
Target version:5.0.0
Resolution:Fixed

Description

The task list extensions will be a very nice addition for Common Mark text formatting.

https://github.com/gjtorikian/commonmarker#extensions

Screenshot_2021-10-09_at_17-25-08.png (10.8 KB) Go MAEDA, 2021-10-09 10:26

0001-Enable-task-list-for-CommonMark-Markdown-formater-35.patch Magnifier (3.47 KB) Marius BALTEANU, 2022-01-04 18:35

0002-Adds-task-list-button-to-toolbar-for-CommonMark-form.patch Magnifier (2.49 KB) Marius BALTEANU, 2022-01-04 20:09

0003-Updates-help-file-for-common_mark-to-include-the-tas.patch Magnifier (1.75 KB) Marius BALTEANU, 2022-01-04 20:24

bt_tl.png (479 Bytes) Marius BALTEANU, 2022-01-22 10:38


Related issues

Related to Redmine - Feature #32424: CommonMark Markdown Text Formatting Closed
Related to Redmine - Feature #20698: Add support for task list items in Textile formatting New

Associated revisions

Revision 21383
Added by Marius BALTEANU 8 months ago

Enable task list items for Common Mark text formatting (#35742).

Revision 21384
Added by Marius BALTEANU 8 months ago

Fix path to task list items icon (#35742).

Revision 21385
Added by Marius BALTEANU 8 months ago

Updates en help file for common_mark to include the task list items feature (#35742).

History

#1 Updated by Marius BALTEANU about 1 year ago

  • Related to Feature #32424: CommonMark Markdown Text Formatting added

#2 Updated by Marius BALTEANU about 1 year ago

  • File 0001-Enable-task-list-for-CommonMark-Markdown-formater-35.patch added

I'm adding a patch for testing purposes, I still need to:

  1. Add tests
  2. Add an icon to JS toolbar
  3. Allow clicking task item checkboxes directly.
  4. Try to add this to Textile

From my point of view, the feature is useful enough only with the first 2 items and we can improve later with 3 and 4. What do you think?

Regarding the tech side, I tried to implement it using only the tasklist extension provided by the CommonMark, but it requires to whitelist in the sanitize the following tags: ul, li, input type="checkbox". Also, using this extensions it will make harder to port this feature to textile.

#3 Updated by Marius BALTEANU 12 months ago

  • Target version set to 5.0.0

I think we should deliver this along with the new CommonMark formatter. Any feedback is appreciated.

#4 Updated by Go MAEDA 12 months ago

Really nice feature. This should be delivered in Redmine 5.0.0.

Marius BALTEANU wrote:

I'm adding a patch for testing purposes, I still need to:

  1. Add tests
  2. Add an icon to JS toolbar
  3. Allow clicking task item checkboxes directly.
  4. Try to add this to Textile

From my point of view, the feature is useful enough only with the first 2 items and we can improve later with 3 and 4. What do you think?

I agree. I think it is still useful even without 2.

#5 Updated by Marius BALTEANU 9 months ago

I've updated the patch to include a test.

#6 Updated by Marius BALTEANU 9 months ago

  • File deleted (0001-Enable-task-list-for-CommonMark-Markdown-formater-35.patch)

#7 Updated by Marius BALTEANU 9 months ago

Here are other two patches:
  • 0002: adds a task list item button to the JS toolbar
  • 0003: updates the help file for en.

Go Maeda, please let me know if I can commit this.

#8 Updated by Marius BALTEANU 8 months ago

  • File bt_tl.png added
  • Status changed from New to Closed
  • Resolution set to Fixed

Feature added in r21383. You can now add task list items using the common_mark format * [ ] Task title or by clicking the "Task list" icon from the toolbar.

For now, to check the items, you need to use the Edit feature, we will try to allow this by clicking on the checkbox in the near future.

#9 Updated by Marius BALTEANU 8 months ago

  • Related to Feature #20698: Add support for task list items in Textile formatting added

#10 Updated by Go MAEDA 6 months ago

  • Subject changed from Enable task list items for Common Mark text formatting to Enable task list items for CommonMark text formatting

Also available in: Atom PDF