Feature #35742

Enable task list items for Common Mark text formatting

Added by Marius BALTEANU 2 months ago. Updated 12 days ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:Marius BALTEANU% Done:

0%

Category:Text formatting
Target version:5.0.0
Resolution:

Description

The task list extensions will be a very nice addition for Common Mark text formatting.

https://github.com/gjtorikian/commonmarker#extensions

0001-Enable-task-list-for-CommonMark-Markdown-formater-35.patch Magnifier (2.28 KB) Marius BALTEANU, 2021-08-15 22:36

Screenshot_2021-10-09_at_17-25-08.png (10.8 KB) Go MAEDA, 2021-10-09 10:26


Related issues

Related to Redmine - Patch #32424: CommonMark Markdown Text Formatting Closed

History

#1 Updated by Marius BALTEANU 2 months ago

  • Related to Patch #32424: CommonMark Markdown Text Formatting added

#2 Updated by Marius BALTEANU 2 months ago

I'm adding a patch for testing purposes, I still need to:

  1. Add tests
  2. Add an icon to JS toolbar
  3. Allow clicking task item checkboxes directly.
  4. Try to add this to Textile

From my point of view, the feature is useful enough only with the first 2 items and we can improve later with 3 and 4. What do you think?

Regarding the tech side, I tried to implement it using only the tasklist extension provided by the CommonMark, but it requires to whitelist in the sanitize the following tags: ul, li, input type="checkbox". Also, using this extensions it will make harder to port this feature to textile.

#3 Updated by Marius BALTEANU 18 days ago

  • Target version set to 5.0.0

I think we should deliver this along with the new CommonMark formatter. Any feedback is appreciated.

#4 Updated by Go MAEDA 12 days ago

Really nice feature. This should be delivered in Redmine 5.0.0.

Marius BALTEANU wrote:

I'm adding a patch for testing purposes, I still need to:

  1. Add tests
  2. Add an icon to JS toolbar
  3. Allow clicking task item checkboxes directly.
  4. Try to add this to Textile

From my point of view, the feature is useful enough only with the first 2 items and we can improve later with 3 and 4. What do you think?

I agree. I think it is still useful even without 2.

Also available in: Atom PDF