Defect #36258
Support revision without any message in Mercurial repositories
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | SCM | |||
| Target version: | 5.0.3 | |||
| Resolution: | Fixed | Affected version: |
Description
In sophesticated position a repository may contain revision without message.
Associated revisions
Support revision without any message in Mercurial repositories (#36258).
Patch by salman mp and Yuichi HARADA.
History
Updated by #4
Updated by salman mp 11 months ago
Go MAEDA wrote:
Thank you, I understand the situation.
Can you please paste the error message in production.log？
Started GET "/projects/test/repository" for 31.57.0.155 at 2021-12-22 11:18:02 +0330
App 2260378 output: Processing by RepositoriesController#show as HTML
App 2260378 output: Parameters: {"id"=>"test"}
App 2260378 output: Current user: user (id=1)
App 2260378 output: Completed 500 Internal Server Error in 706ms (ActiveRecord: 6.4ms)
App 2260378 output:
App 2260378 output: TypeError (no implicit conversion of nil into String):
App 2260378 output:
App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:233:in `unescape'
App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:233:in `block in each_revision'
App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:203:in `each'
App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:203:in `each_revision'
App 2260378 output: app/models/repository/mercurial.rb:194:in `block in fetch_changesets'
App 2260378 output: app/models/repository/mercurial.rb:193:in `step'
App 2260378 output: app/models/repository/mercurial.rb:193:in `fetch_changesets'
App 2260378 output: app/controllers/repositories_controller.rb:87:in `show'
App 2260378 output: lib/redmine/sudo_mode.rb:61:in `sudo_mode'
#5
Updated by Yuichi HARADA 11 months ago
- File 0001-Update-test-fixtures-repositories-mercurial_reposito.patch
added - File 0002-Update-tests-and-add-a-test-for-empty-commit-message.patch added
I have confirmed this issue. Applying the patch(empty_message.diff) solved it. thank you.
I created MercurialAdapterTest#test_empty_message because there was no test.
#8
Updated by Future Link Corporation pkgsrc team 3 months ago
Any way we can get this merged ASAP? It's the only issue blocking 5.0.3. We're unable to upgrade our Redmine ATM, because pkgsrc has Rails 6.1.6.1 which is supported only by the next minor release.