Patch #36258
Support revision without any message
Status: | New | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | - | % Done: | 0% | |
Category: | SCM | |||
Target version: | Candidate for next minor release |
Description
In sophesticated position a repository may contain revision without message.
History
#4
Updated by salman mp 6 months ago
Go MAEDA wrote:
Thank you, I understand the situation.
Can you please paste the error message in production.log?
Started GET "/projects/test/repository" for 31.57.0.155 at 2021-12-22 11:18:02 +0330 App 2260378 output: Processing by RepositoriesController#show as HTML App 2260378 output: Parameters: {"id"=>"test"} App 2260378 output: Current user: user (id=1) App 2260378 output: Completed 500 Internal Server Error in 706ms (ActiveRecord: 6.4ms) App 2260378 output: App 2260378 output: TypeError (no implicit conversion of nil into String): App 2260378 output: App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:233:in `unescape' App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:233:in `block in each_revision' App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:203:in `each' App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:203:in `each_revision' App 2260378 output: app/models/repository/mercurial.rb:194:in `block in fetch_changesets' App 2260378 output: app/models/repository/mercurial.rb:193:in `step' App 2260378 output: app/models/repository/mercurial.rb:193:in `fetch_changesets' App 2260378 output: app/controllers/repositories_controller.rb:87:in `show' App 2260378 output: lib/redmine/sudo_mode.rb:61:in `sudo_mode'
#5
Updated by Yuichi HARADA 6 months ago
- File 0001-Update-test-fixtures-repositories-mercurial_reposito.patch
added
- File 0002-Update-tests-and-add-a-test-for-empty-commit-message.patch
added
I have confirmed this issue. Applying the patch(empty_message.diff) solved it. thank you.
I created MercurialAdapterTest#test_empty_message
because there was no test.