Project

General

Profile

Actions

Defect #36258

closed

Support revision without any message in Mercurial repositories

Added by salman mp over 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
SCM
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

In sophesticated position a repository may contain revision without message.


Files

Actions #1

Updated by Go MAEDA over 2 years ago

I'm not familiar with Mercurial, so I don't understand the improvements the patch brings. Could you explain the benefits?

Actions #2

Updated by salman mp over 2 years ago

Mercurial is very similar to git. I added another source to my repository, and when did pull from that source, unbelievably there is a revision without any commit message. When I wanted to fetch changesets, there was an exception (line that patched).

Actions #3

Updated by Go MAEDA over 2 years ago

Thank you, I understand the situation.

Can you please paste the error message in production.log?

Actions #4

Updated by salman mp over 2 years ago

Go MAEDA wrote:

Thank you, I understand the situation.

Can you please paste the error message in production.log?

Started GET "/projects/test/repository" for 31.57.0.155 at 2021-12-22 11:18:02 +0330
App 2260378 output: Processing by RepositoriesController#show as HTML
App 2260378 output:   Parameters: {"id"=>"test"}
App 2260378 output:   Current user: user (id=1)
App 2260378 output: Completed 500 Internal Server Error in 706ms (ActiveRecord: 6.4ms)
App 2260378 output:   
App 2260378 output: TypeError (no implicit conversion of nil into String):
App 2260378 output:   
App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:233:in `unescape'
App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:233:in `block in each_revision'
App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:203:in `each'
App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:203:in `each_revision'
App 2260378 output: app/models/repository/mercurial.rb:194:in `block in fetch_changesets'
App 2260378 output: app/models/repository/mercurial.rb:193:in `step'
App 2260378 output: app/models/repository/mercurial.rb:193:in `fetch_changesets'
App 2260378 output: app/controllers/repositories_controller.rb:87:in `show'
App 2260378 output: lib/redmine/sudo_mode.rb:61:in `sudo_mode'

Actions #6

Updated by Go MAEDA over 2 years ago

  • Target version set to Candidate for next minor release
Actions #7

Updated by Go MAEDA almost 2 years ago

  • Target version changed from Candidate for next minor release to 5.0.3

Setting the target version to 5.0.3.

Actions #8

Updated by Future Link Corporation pkgsrc team over 1 year ago

Any way we can get this merged ASAP? It's the only issue blocking 5.0.3. We're unable to upgrade our Redmine ATM, because pkgsrc has Rails 6.1.6.1 which is supported only by the next minor release.

Actions #9

Updated by Go MAEDA over 1 year ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patches. Thank you for your contribution.

Actions #10

Updated by Go MAEDA over 1 year ago

  • Status changed from Closed to Reopened
Actions #11

Updated by Go MAEDA over 1 year ago

  • Status changed from Reopened to Closed
Actions #12

Updated by Go MAEDA over 1 year ago

  • Tracker changed from Patch to Defect
  • Subject changed from Support revision without any message to Support revision without any message in Mercurial repositories
  • Resolution set to Fixed
Actions

Also available in: Atom PDF